Skip to content

Conversation

@omar711
Copy link
Contributor

@omar711 omar711 commented Oct 10, 2023

Description:

Adds a * string in front of the active cluster, if a cluster has been set.

Running on a new install, where kurtosis cluster set has never been run:

√ kurtosis % ./cli/cli/scripts/launch-cli.sh cluster ls
   Name
   docker
   minikube

Once a cluster has been set:

√ kurtosis % ./cli/cli/scripts/launch-cli.sh cluster ls
    Name
*   docker
    minikube

I've used the table_printer to match what context cli ls does.

Is this change user facing?

YES

References (if applicable):

#1508

@omar711 omar711 requested a review from a team October 11, 2023 20:19
@omar711 omar711 marked this pull request as ready for review October 11, 2023 20:19
@omar711 omar711 enabled auto-merge (squash) October 11, 2023 20:20
@omar711 omar711 disabled auto-merge October 11, 2023 21:49
@omar711
Copy link
Contributor Author

omar711 commented Oct 11, 2023

Golang testsuite failed there. It looks random, errors destroying an enclave during tests, and they don't seem close to this code. I'll poke this to retrigger the build and see whether that plays out ok.

Capturing the error here for the moment:

time="2023-10-11T20:22:45Z" level=error msg="An error occurred destroying enclave 'go-test-startosis-add-service-1697055759' that we created for this test:\nAn error occurred destroying enclave with identifier 'go-test-startosis-add-service-1697055759'\n --- at /home/circleci/project/api/golang/engine/lib/kurtosis_context/kurtosis_context.go:254 (KurtosisContext.DestroyEnclave) ---\nCaused by: rpc error: code = Unknown desc = An error occurred destroying enclave with identifier 'go-test-startosis-add-service-1697055759':\n --- at /home/circleci/project/engine/server/engine/server/engine_connect_server_service.go:140 (EngineConnectServerService.DestroyEnclave) ---\nCaused by: An error occurred while fetching enclave uuid for identifier 'go-test-startosis-add-service-1697055759'\n --- at /home/circleci/project/engine/server/engine/enclave_manager/enclave_manager.go:246 (EnclaveManager.DestroyEnclave) ---\nCaused by: An error occurred while getting enclaves to look up if identifier 'go-test-startosis-add-service-1697055759' is a valid uuid\n --- at /home/circleci/project/engine/server/engine/enclave_manager/enclave_manager.go:606 (EnclaveManager.getEnclaveUuidForIdentifierUnlocked) ---\nCaused by: Error thrown retrieving enclaves\n --- at /home/circleci/project/engine/server/engine/enclave_manager/enclave_manager.go:512 (EnclaveManager.getEnclavesWithoutMutex) ---\nCaused by: An error occurred getting enclaves using filters: &{UUIDs:map[] Statuses:map[]}\n --- at /home/circleci/project/container-engine-lib/lib/backend_impls/metrics_reporting/metrics_reporting_kurtosis_backend.go:128 (MetricsReportingKurtosisBackend.GetEnclaves) ---\nCaused by: An error occurred getting enclave networks matching filters '&{UUIDs:map[] Statuses:map[]}'\n --- at /home/circleci/project/container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go:182 (DockerKurtosisBackend.GetEnclaves) ---\nCaused by: An error occurred getting enclave status and containers from network for enclave '76801273184a4656bdc9207d16774ed9'\n --- at /home/circleci/project/container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go:451 (DockerKurtosisBackend.getMatchingEnclaveNetworkInfo) ---\nCaused by: An error occurred getting the containers for enclave '76801273184a4656bdc9207d16774ed9'\n --- at /home/circleci/project/container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go:482 (DockerKurtosisBackend.getEnclaveStatusAndContainers) ---\nCaused by: An error occurred getting the containers for enclave '76801273184a4656bdc9207d16774ed9' by labels 'map[com.kurtosistech.app-id:kurtosis com.kurtosistech.enclave-id:76801273184a4656bdc9207d16774ed9]'\n --- at /home/circleci/project/container-engine-lib/lib/backend_impls/docker/docker_kurtosis_backend/docker_kurtosis_backend_enclave_functions.go:519 (DockerKurtosisBackend.getAllEnclaveContainers) ---\nCaused by: An error occurred getting containers with labels '{fields:map[label:map[com.kurtosistech.app-id=kurtosis:true com.kurtosistech.enclave-id=76801273184a4656bdc9207d16774ed9:true]]}'\n --- at /home/circleci/project/container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go:1178 (DockerManager.GetContainersByLabels) ---\nCaused by: An error occurred inspecting the docker container with ID '8671a0dab041c06c5d8358d8d1984d0ac0e8098bbaf9f7450e73ef676f9205a0'\n --- at /home/circleci/project/container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go:1736 (DockerManager.getContainersByFilterArgs) ---\nCaused by: An error occurred inspecting container '8671a0dab041c06c5d8358d8d1984d0ac0e8098bbaf9f7450e73ef676f9205a0'\n --- at /home/circleci/project/container-engine-lib/lib/backend_impls/docker/docker_manager/docker_manager.go:498 (DockerManager.InspectContainer) ---\nCaused by: Error response from daemon: No such container: 8671a0dab041c06c5d8358d8d1984d0ac0e8098bbaf9f7450e73ef676f9205a0"
time="2023-10-11T20:22:45Z" level=error msg="ACTION REQUIRED: You'll need to destroy enclave 'go-test-startosis-add-service-1697055759' manually!!!!"

https://app.circleci.com/pipelines/github/kurtosis-tech/kurtosis/7775/workflows/b40031d3-47fd-43b9-8265-94fe5d59ea5e/jobs/105604

@omar711 omar711 merged commit 67e0111 into main Oct 11, 2023
@omar711 omar711 deleted the omar/highlight-active-cluster branch October 11, 2023 22:18
@omar711
Copy link
Contributor Author

omar711 commented Oct 11, 2023

Yep - failure was a random one

adschwartz pushed a commit that referenced this pull request Oct 12, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.84.5](0.84.4...0.84.5)
(2023-10-12)


### Features

* highlight the active cluster in kurtosis cluster ls
([#1514](#1514))
([67e0111](67e0111))
* local replace package dependency
([#1521](#1521))
([d5e3126](d5e3126))
* manage script return value
([#1546](#1546))
([a53508f](a53508f))


### Bug Fixes

* run package bug
([#1539](#1539))
([1f5380a](1f5380a)),
closes [#1501](#1501)
[#1479](#1479)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants