fix: run package bug #1539
Merged
fix: run package bug #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedim52
approved these changes
Oct 12, 2023
Collaborator
tedim52
left a comment
There was a problem hiding this comment.
LGTM pending status checks
leoporoli
pushed a commit
that referenced
this pull request
Oct 12, 2023
## Description: Fixing these bugs: * Mishandling of the internal representation of JSON objects in the package manager form fields * Default data type for fields is now set to JSON * Invalid json fields were not failing the validity checker on the field. Fixed as well. ## Is this change user facing? YES ## References (if applicable): Closes #1501 Closes #1479
adschwartz
pushed a commit
that referenced
this pull request
Oct 12, 2023
🤖 I have created a release *beep* *boop* --- ## [0.84.5](0.84.4...0.84.5) (2023-10-12) ### Features * highlight the active cluster in kurtosis cluster ls ([#1514](#1514)) ([67e0111](67e0111)) * local replace package dependency ([#1521](#1521)) ([d5e3126](d5e3126)) * manage script return value ([#1546](#1546)) ([a53508f](a53508f)) ### Bug Fixes * run package bug ([#1539](#1539)) ([1f5380a](1f5380a)), closes [#1501](#1501) [#1479](#1479) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing these bugs:
Is this change user facing?
YES
References (if applicable):
Closes #1501
Closes #1479