MavLinkCom subscriber id may give invalid ids

[ditlef]

The id is: static_cast(listeners.size() + 1)

Subscibe two listeners:
=> L1 = 1, L2 = 2
Unsubscribe L1.
=> L2 is invalid.
Add Subsciption:
=> L3 = 2 (L2 = 2)

[sytelus]

Thanks for reporting the issue. Looks like bug is in this line. We need to use C++ remove-erase idiom. Please feel free to make a local change and see if that works.

[ditlef]

The problem is using the size of the listeners collection as the ID. I made a quick fix that will work until allocating 4Giga listeners. A more solid fix is ensuring unique number: Maybe: set<int> listenersIds; allocate: Find int (1..) not in set. Add to set. release: Remove from set. My fix: private: int nextListenerId = 1; int MavLinkConnectionImpl::subscribe(MessageHandler handler) { - MessageHandlerEntry entry = { static_cast<int>(listeners.size() + 1), handler = handler }; + MessageHandlerEntry entry = { static_cast<int>(nextListenerId++), handler = handler };

…

On Mon, Jul 17, 2017 at 10:37 AM, Shital Shah ***@***.***> wrote: Thanks for reporting the issue. Looks like bug is in this line <https://github.com/Microsoft/AirSim/blob/master/MavLinkCom/src/impl/MavLinkConnectionImpl.cpp#L326>. We need to use C++ remove-erase idiom. Please feel free to make a local change and see if that works. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#347 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ac06GgyC5jyuSCcQIt8HgF0BgR6lehccks5sOx1IgaJpZM4OZm1b> .