Fix simLoadLevel and Levels OptionsMenu #4551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alonfaraj Thanks for this contribution. I agree that this is the right approach. Thanks for the detailed explanation. I didn't remember where was the list to include other levels 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4432
Fixes: #4542
About
This PR fix load level mechanism, simplify and cleanup the whole process.
OptionsMenuwas fixed as well to list the available maps under/Gamefolder only.Till now, load level was loading the level as streaming level on top of the existing level.
As far as I understand, this logic assume a level is always exists and keep loading the rest of the levels as streaming levels which is not the desired behavior.
I have used a simpler method,
UGameplayStatics::OpenLevelinstead ofAirsimLevelStreamingclass which is not needed.This method take care of unload and load the requested level, and make it Persistent.
How Has This Been Tested?
Run the blocks project and switch between 2 levels with different
PlayerStartpositions, as well as using the python API.Tested on packaged game (windows) as well.
To test it on package, you should specify the desired maps:
Project settings -> packaging -> List of maps to include in packages buildScreenshots (if appropriate):
capture.mp4