Skip to content

'msr::airlib::RealMultirotorConnector' is an abstract class #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeremyfix opened this issue Oct 30, 2017 · 3 comments
Closed

'msr::airlib::RealMultirotorConnector' is an abstract class #572

jeremyfix opened this issue Oct 30, 2017 · 3 comments

Comments

@jeremyfix
Copy link
Contributor

jeremyfix commented Oct 30, 2017

When running build.sh , an error is thrown because 'msr::airlib::RealMultirotorConnector' is an abstract class. Indeed, the following two virtual pure methods are not overriden :

virtual bool setSegmentationObjectID(const std::string& mesh_name, int object_id,
bool is_name_regex = false) = 0;

virtual int getSegmentationObjectID(const std::string& mesh_name) = 0;

in the file AirSim/AirLib/include/vehicles/multirotor/controllers/RealMultirotorConnector.hpp and it inherits from AirSim/AirLib/include/controllers/VehicleConnectorBase.hpp

I succeed in building AirSim, by simply defining these two methods in RealMultirotorConnector.hpp with an empty body , but I do not know if this the expected behavior.

@nwayt001
Copy link

nwayt001 commented Nov 1, 2017

I had the same error, did what you did and it worked for me. I'm not sure what effect this will have though.

@sytelus
Copy link
Contributor

sytelus commented Nov 2, 2017

Thanks for reporting this. This is now fixed.

@sytelus sytelus closed this as completed Nov 2, 2017
@tmericli
Copy link

tmericli commented Nov 28, 2017

The problem still seems to persist; this time complaining about the following virtual function that is not implemented in RealMultirotorConnector.hpp:

virtual void printLogMessage(const std::string& message, std::string message_param = "", unsigned char severity = 0)

Temporarily adding that function to RealMultirotorConnector.hpp with an empty body solves the build problem, but a more principled solution is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants