Skip to content

asynchronous support? #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fuad00 opened this issue Dec 13, 2024 · 3 comments
Open

asynchronous support? #13

fuad00 opened this issue Dec 13, 2024 · 3 comments
Labels
enhancement New feature or request open for contribution Invites open-source developers to contribute to the project.

Comments

@fuad00
Copy link

fuad00 commented Dec 13, 2024

Any plans on this?

@gagb gagb added the enhancement New feature or request label Dec 13, 2024
@gagb
Copy link
Contributor

gagb commented Dec 13, 2024

There is no current plan yet, but PRs welcome! @afourney

@gagb gagb added the help wanted Extra attention is needed label Dec 14, 2024
@0xRaduan
Copy link

Would be great, I can try to take a stab on this tomorrow.

@gagb gagb added open for contribution Invites open-source developers to contribute to the project. and removed help wanted Extra attention is needed labels Dec 14, 2024
@0xRaduan
Copy link

Just an update from my end: I checked the current implementation, and while there are some benefits of async support, many libraries that are used under the hood, are not supporting async:

  • markdownify
  • mammoth
  • pandas
  • pdfminer
  • python-pptx

At this point, if all underlying calls will be sync, I am not sure, how much benefit it would give to provide async APIs on markitdown, outside of a thin wrapper. Otherwise, we need a full rewrite + using a full new set of libraries.

If people want to use MarkItDown in async manner, I think they should just create a thin wrapper for markitdown.

I did a tiny PR on how I would do that: #32;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request open for contribution Invites open-source developers to contribute to the project.
Projects
None yet
Development

No branches or pull requests

3 participants