Skip to content

"Description" hardcoded in English when converting images to another language #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sglebs opened this issue Feb 4, 2025 · 1 comment

Comments

@sglebs
Copy link

sglebs commented Feb 4, 2025

This is hardcoded: and it should not:

        if llm_client is not None and llm_model is not None:
            md_content += (
                "\n# Description:\n"
                + self._get_llm_description(
                    local_path,
                    extension,
                    llm_client,
                    llm_model,
                    prompt=kwargs.get("llm_prompt"),
                ).strip()
                + "\n"
            )

If I am passing a prompt, let ME control if I want a "Description" heading or not, and in what language it should be.

Suggestion: only append it if the prompt is None.

@afourney
Copy link
Member

afourney commented Feb 9, 2025

Good point. The library was originally designed to allow LLMs to read various file formats -- and they are inherently multilingual. But, I agree this is not appropriate for other use-cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants