Make line widths customizable #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Merged, thanks! I had to make a couple of small changes to work with other contributions, and I altered some variable and config names to read a little easier. Could you also write some documentation for these changes? Thanks again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I extended the Morris.Line class to support customization of the line widths when several , in a similar way of point widths and line colors. The use case originating this PR is to be able to draw boundary lines above and under the main depicted line. This will work in a similar way of goals do, but not only horizontal. Example: percentile of growth over age graphs for children.
For the sake of backwards compatibility, I've not changed the attribute name
lineWidthfor the plural formlineWidth. I also allow both an Array of sizes and a single size to be provided. Is this a good approach?I hope this is simple enough to be considered for Morris' codebase.
Cheers!