Skip to content

Commit 0842bda

Browse files
committed
Revert last commit. Weird things happen when using "i" for args
Numbers that didn't originate in C (example: defining HIGH as 1 in mruby) can cause the function to do nothing
1 parent 7e3eeff commit 0842bda

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/gpio.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ static mrb_value
2727
mrb_esp32_gpio_pin_mode(mrb_state *mrb, mrb_value self) {
2828
mrb_value pin, dir;
2929

30-
mrb_get_args(mrb, "ii", &pin, &dir);
30+
mrb_get_args(mrb, "oo", &pin, &dir);
3131

3232
if (!mrb_fixnum_p(pin) || !mrb_fixnum_p(dir)) {
3333
return mrb_nil_value();
@@ -55,7 +55,7 @@ static mrb_value
5555
mrb_esp32_gpio_digital_read(mrb_state *mrb, mrb_value self) {
5656
mrb_value pin;
5757

58-
mrb_get_args(mrb, "i", &pin);
58+
mrb_get_args(mrb, "o", &pin);
5959

6060
if (!mrb_fixnum_p(pin)) {
6161
return mrb_nil_value();
@@ -69,7 +69,7 @@ static mrb_value
6969
mrb_esp32_gpio_digital_write(mrb_state *mrb, mrb_value self) {
7070
mrb_value pin, level;
7171

72-
mrb_get_args(mrb, "ii", &pin, &level);
72+
mrb_get_args(mrb, "oo", &pin, &level);
7373

7474
if (!mrb_fixnum_p(pin) || !mrb_fixnum_p(level)) {
7575
return mrb_nil_value();
@@ -85,7 +85,7 @@ static mrb_value
8585
mrb_esp32_gpio_analog_read(mrb_state *mrb, mrb_value self) {
8686
mrb_value ch;
8787

88-
mrb_get_args(mrb, "i", &ch);
88+
mrb_get_args(mrb, "o", &ch);
8989

9090
if (!mrb_fixnum_p(ch)) {
9191
return mrb_nil_value();
@@ -121,7 +121,7 @@ static mrb_value
121121
mrb_esp32_gpio_analog_write(mrb_state *mrb, mrb_value self) {
122122
mrb_value ch, vol;
123123

124-
mrb_get_args(mrb, "ii", &ch, &vol);
124+
mrb_get_args(mrb, "oo", &ch, &vol);
125125

126126
if (!mrb_fixnum_p(ch) || !mrb_fixnum_p(vol)) {
127127
return mrb_nil_value();

0 commit comments

Comments
 (0)