Skip to content

fix for msvc #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix for msvc #27

wants to merge 1 commit into from

Conversation

sdcg1994
Copy link

@sdcg1994 sdcg1994 commented Feb 9, 2022

unistd.h is not used for msvc, it should be replaced with direct.h

@sdcg1994 sdcg1994 closed this Feb 9, 2022
@rsomla1
Copy link
Contributor

rsomla1 commented Feb 9, 2022

Normally this file is not needed/used when building on Windows with msvc. However, it might become a problem if using msvc with clang or using ninja on Windows. I will investigate that.

@sdcg1994
Copy link
Author

sdcg1994 commented Feb 9, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants