Make only column names enumerable in RowDataPacket

closes #549
fixes #895

Author: dougwilson

Changes.md

@@ -8,6 +8,7 @@ you spot any mistakes.
 
 * Add `enqueue` event to protocol and connection #381
 * Blacklist unsupported connection flags #881
+* Make only column names enumerable in `RowDataPacket` #549 #895
 
 ## v2.4.3 (2014-08-25)
 

lib/protocol/packets/RowDataPacket.js

@@ -7,7 +7,19 @@ module.exports = RowDataPacket;
 function RowDataPacket() {
 }
 
-RowDataPacket.prototype.parse = function(parser, fieldPackets, typeCast, nestTables, connection) {
+Object.defineProperty(RowDataPacket.prototype, 'parse', {
+  configurable: true,
+  enumerable: false,
+  value: parse
+});
+
+Object.defineProperty(RowDataPacket.prototype, '_typeCast', {
+  configurable: true,
+  enumerable: false,
+  value: typeCast
+});
+
+function parse(parser, fieldPackets, typeCast, nestTables, connection) {
   var self = this;
   var next = function () {
     return self._typeCast(fieldPacket, parser, connection.config.timezone, connection.config.supportBigNumbers, connection.config.bigNumberStrings, connection.config.dateStrings);
@@ -36,9 +48,9 @@ RowDataPacket.prototype.parse = function(parser, fieldPackets, typeCast, nestTab
       this[fieldPacket.name] = value;
     }
   }
-};
+}
 
-RowDataPacket.prototype._typeCast = function(field, parser, timeZone, supportBigNumbers, bigNumberStrings, dateStrings) {
+function typeCast(field, parser, timeZone, supportBigNumbers, bigNumberStrings, dateStrings) {
   var numberString;
 
   switch (field.type) {
@@ -105,4 +117,4 @@ RowDataPacket.prototype._typeCast = function(field, parser, timeZone, supportBig
     default:
       return parser.parseLengthCodedString();
   }
-};
+}

test/unit/query/test-result-rows-enumerate.js

@@ -0,0 +1,30 @@
+var assert     = require('assert');
+var common     = require('../../common');
+var connection = common.createConnection({port: common.fakeServerPort});
+
+var server = common.createFakeServer();
+
+server.listen(common.fakeServerPort, function (err) {
+  assert.ifError(err);
+
+  connection.query('SELECT CURRENT_USER()', function (err, rows) {
+    assert.ifError(err);
+    assert.equal(rows.length, 1);
+
+    var row = rows[0];
+    var keys = Object.keys(row).sort();
+
+    assert.equal(keys.length, 1);
+    assert.deepEqual(keys, ['CURRENT_USER()']);
+
+    var forin = [];
+    for (var column in row) {
+      forin.push(column);
+    }
+
+    assert.deepEqual(forin, keys);
+
+    connection.destroy();
+    server.destroy();
+  });
+});