Skip to content

Commit c1a01b7

Browse files
committed
Partial fix for localwiki#280, for images already on the page
1 parent f73ae26 commit c1a01b7

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

sapling/pages/static/js/ckeditor/_source/plugins/simpleimage/dialogs/simpleimage.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -876,6 +876,13 @@ For licensing, see LICENSE.html or http://ckeditor.com/license
876876
element.removeClass("image_right");
877877
if ( value ) {
878878
element.addClass("image_" + value);
879+
// Move to top level in the DOM when floated
880+
top_level = jQuery(element.$).parentsUntil('body,td,th').last();
881+
if(top_level.length)
882+
{
883+
jQuery(element.$).remove();
884+
top_level.before(jQuery(element.$));
885+
}
879886
}
880887

881888
if ( !internalCommit && type == IMAGE )

sapling/pages/static/js/ckeditor/_source/plugins/simpleimage/plugin.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ CKEDITOR.plugins.add( 'simpleimage',
140140
var oldHtml = oldFrame.length ? oldFrame.outerHTML() : img.outerHTML();
141141
img.addClass('cke_moved');
142142
oldFrame.addClass('cke_moved');
143+
var floated = oldFrame.hasClass('image_right') || oldFrame.hasClass('image_left');
143144
var moveImage = function(evt){
144145
oldFrame.remove();
145146
var moved_image = jQuery('img.cke_moved', editor.document.$);
@@ -160,7 +161,13 @@ CKEDITOR.plugins.add( 'simpleimage',
160161
outerFrame.before(oldHtml);
161162
else outerFrame.after(oldHtml);
162163
} else {
163-
moved_element.before(oldHtml);
164+
where_to_drop = moved_element;
165+
if(floated)
166+
{
167+
top_level = moved_element.parentsUntil('body,td,th').last();
168+
where_to_drop = top_level;
169+
}
170+
where_to_drop.before(oldHtml);
164171
}
165172
// fix the cursor position
166173
var selection = editor.getSelection();

0 commit comments

Comments
 (0)