I don't know if it should print a warning, because then -warnings-as-errors will kill your build instead of fixing the bug. All it should probably do is wipe out the deferred call if said target call is disabled, even though the code is correct.

I'm one of those people who always compiles with odin build . -vet -vet-tabs -strict-style -vet-style -warnings-as-errors -disallow-do. 😂

I can toss that out. I made it a warning because that's what I did when I fixed disabled @(init). Should that also not be a warning? My intent was consistency.

I can toss that out. I made it a warning because that's what I did when I fixed disabled @(init). Should that also not be a warning? My intent was consistency.

That's more likely to be an unintentional error. You run things under @(init) for a reason. If you want to disable it, you could also add a when DISABLED_REASON { return } as the first thing in those rare few exceptions where you don't want the warning, but also for that particular init to not do anything.

(These things are hard, aren't they, deciding sane defaults? But we can always revisit these decisions if we get feedback on these particular obscure use cases.)

(These things are hard, aren't they, deciding sane defaults? But we can always revisit these decisions if we get feedback on these particular obscure use cases.)

Yeah, I have a tendency to go for caution and informing the user as much as possible, but I can also see this being a less annoying result if it's commonplace for someone to have disabled deferrals for some reason.

That's twice now that github's CDN failed:

Downloading PNG assets
	Downloading https://raw.githubusercontent.com/odin-lang/test-assets/master/PNG/PNG.zip to /home/runner/work/Odin/Odin/tests/core/assets/PNG/PNG.zip
Could not download https://raw.githubusercontent.com/odin-lang/test-assets/master/PNG/PNG.zip
Could not download ZIP file
/home/runner/work/Odin/Odin/tests/core/normal.odin([8](https://github.com/odin-lang/Odin/actions/runs/15126321729/job/42518940421?pr=5183#step:15:9):3) panic: downloading test assets failed!

I've had issues with downloading the test assets locally today too.

(These things are hard, aren't they, deciding sane defaults? But we can always revisit these decisions if we get feedback on these particular obscure use cases.)

Yeah, I have a tendency to go for caution and informing the user as much as possible, but I can also see this being a less annoying result if it's commonplace for someone to have disabled deferrals for some reason.

I can see wanting to be cautious, but I also figure that if you're going out of your way to use deferred and disabled together, you're telling the compiler you at least think you know what you're doing. Neither is a beginner idiom, let alone together.

And FreeBSD caps it off with a "VM is booting" loop. I think I'll merge the patch. :-)

Confirmed the fix works locally. Thanks as always, Feoramund.