Incompatible with PHPUnit >= 10.3

[mac89]

Caused by making the $properties property read only: sebastianbergmann/phpunit@eb2d761

[gaglioffo]

I have the same issue:

Error: Cannot modify readonly property PHPUnit\Framework\MockObject\Invocation::$parameters

...\php-mock\php-mock-phpunit\classes\DefaultArgumentRemoverReturnTypes100.php:76

[herndlm]

I was looking into this a bit and found out the following so far

• reflection cannot be used to modify readonly properties -> https://wiki.php.net/rfc/readonly_properties_v2#reflection
• simply creating a new instance of Invocation can also not be done because it does not have a getter for its private prop returnType which is needed for construction

Since the whole modification of default params in Invocation is already a hack (Invocation is internal, private parameters are modified via closure binding) we could use reflection to only access returnType and then "cleanly" create a new instance of Invocation maybe?

E.g. I tried the following (only in the one place that broke a test for us!) and it seems to work

private function removeDefaultArguments(Invocation $invocation, string $class)
    {
        $parameters = $invocation->parameters();
        MockFunctionGenerator::removeDefaultArguments($parameters);

        $returnTypePropertyReflection = new \ReflectionProperty(Invocation::class, 'returnType');
        $returnTypePropertyReflection->setAccessible(true);

        $invocation = new Invocation(   
            $invocation->className(),
            $invocation->methodName(),
            $parameters,
            $returnTypePropertyReflection->getValue($invocation),
            $invocation->object()
        );
    }

[michalbundyra]

@herndlm I was looking into it as well, and I have no solution yet. I am worried we might not have one, or we would need to came up with something else. Yes, this library hacks PHPUnits, and it's already so complex to support all PHPUnit versions.

Thanks for investigation, I'll try to dig a bit more once I have a bit more time. Thanks again

[herndlm]

oh, right, and in my proposed fix I missed that the passed $invocation is not overwritten / returned, so It's not doing anything 🤦‍♂️

additionally (missed in the previous points):

• Invocation is final, so changing it's behaviour via child class is not possible
• Invocation doesn't have a useful interface and is used directly, so using a decorator to change it's behaviour is also not possible

[MekkiLakhdher]

I am facing the same issue :

Error: Cannot modify readonly property PHPUnit\Framework\MockObject\Invocation::$parameters
...\php-mock\php-mock-phpunit\classes\DefaultArgumentRemoverReturnTypes100.php:76

The solution that worked for me is simply using \PHPUnit\Framework\MockObject\Invocation::parameters method which is the getter of the readonly $parameters variable.

Here are the necessary changes :

/php-mock/php-mock-phpunit/classes/DefaultArgumentRemoverReturnTypes100.php:41
- MockFunctionGenerator::removeDefaultArguments($invocation->parameters);
+ MockFunctionGenerator::removeDefaultArguments($invocation->parameters());

And

/php-mock/php-mock-phpunit/classes/DefaultArgumentRemoverReturnTypes100.php:76
- MockFunctionGenerator::removeDefaultArguments($this->parameters);
+ MockFunctionGenerator::removeDefaultArguments($this->parameters());

[michalbundyra]

@MekkiLakhdher it does not seem to be working - see: #62 (commit: 1dfcf66)

[herndlm]

nice, thx @marcoscoelho. I can finally merge this one :D