Skip to content

Latest version of khal yields error messages for VTODO items when reindexing #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
untitaker opened this issue Sep 20, 2014 · 6 comments
Closed

Latest version of khal yields error messages for VTODO items when reindexing #114

untitaker opened this issue Sep 20, 2014 · 6 comments
Labels
needs tests

Comments

@untitaker
Copy link
Member

No description provided.

@untitaker
Copy link
Member Author

Ah, i think this is because the error raising for UpdateFailed fails because of nonascii content.

@untitaker
Copy link
Member Author

Actually no, it's unrelated. The raising of UpdateFailed in https://github.com/geier/khal/blob/master/khal/khalendar/backend.py#L243 is presented as a critical error, when it is not.

@geier
Copy link
Member

geier commented Sep 20, 2014

thanks, will try to fix this asap

@geier
Copy link
Member

geier commented Sep 22, 2014

542be65 , still need some tests though

untitaker added a commit that referenced this issue Sep 30, 2014
@untitaker
Use native strings for logging
6c54850 
The fix for #114 doesn't work if the item contains nonascii characters.
The ical variable seems to be a bytestring, and when formatting it into
a unicode string, Python wants to decode it with the ascii codec. Doing
so raises a UnicodeError (instead of UpdateFailed) and we still get an
error message with normal logging settings.
untitaker added a commit that referenced this issue Sep 30, 2014
@untitaker
Add testcase for #114
2a02f62
@untitaker
Copy link
Member Author

My testcase doesn't assert the logging output, but only asserts that no extra information is printed on stdout.

@geier
Copy link
Member

geier commented Sep 30, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geier @untitaker