Skip to content

Layout of the EventEditor #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geier opened this issue Jul 16, 2015 · 10 comments
Open

Layout of the EventEditor #226

geier opened this issue Jul 16, 2015 · 10 comments

Comments

@geier
Copy link
Member

geier commented Jul 16, 2015

Let's discuss how the EventEditor (and EventViewer) should look here. See #225 for some first ideas (but please do copy your ideas here).

@untitaker
Copy link
Member

I wonder if it's a good idea could implement that trend of grey labels inside the textboxes that disappear once you enter text. I'm not sure if that'd be rather confusing than anything else.

For now I suggest making the labels gray, that already helps.

@geier
Copy link
Member Author

geier commented Jul 16, 2015

I'm not entirely sure what you mean, but I haven't thought a second
about that color scheme (if you want to call it that).

Quoting Markus Unterwaditzer (2015-07-16 12:22:16)

I wonder if it's a good idea could implement that trend of grey labels inside the textboxes that disappear once you enter text. I'm not sure if that'd be rather confusing than anything else.

For now I suggest making the labels gray, that already helps.


Reply to this email directly or view it on GitHub:
#226 (comment)

@pdav
Copy link
Contributor

pdav commented Jul 16, 2015

I would like to enter vi (or any external command as specified in the config file) to edit an event.

@untitaker
Copy link
Member

Related to #179 and #31

I'm not sure if using an external editor is sensible for anything other than summary or description.

@pdav
Copy link
Contributor

pdav commented Jul 17, 2015

An external editor is suitable for:

  • summary
  • description
  • location
  • start and end dates (as with the existing editor)
  • category (to be added to the editor)

Recurrences may be added:

  • either in the external editor with a simple mini-language (such as [on 1|2|..|31|monday|tuesday|...]) [every [month|week|day] [for n day|week|month])
  • or by ikhal if "no" is replaced by "yes" in a line such as "Repeat: no"

@WhyNotHugo
Copy link
Member

I think aligned labels and fields would look quite a bit better.
Instead of

Location: ___
Description: ___
From: ___
Location:    ___
Description: ___
From:        ___

The save button does not need to be full-width, and a cancel button might make sense to accompany it.

The rest of the editor looks pretty sensible right now, though we might want to keep an eye open for other fields (recursion details, category, etc).

@coachshea
Copy link
Contributor

I would like to second the notion of using an external editor. Possibly similar to how khard does it.

@libre-man
Copy link

This could be done pretty easily by editing the EventColumn.new_event and EventColumn.edit function to check the config if the user wants to use an external editor and if so open a template for the event and then parse the saved text. This would be the same as khard does this. I would be willing to implement it.

@geier
Copy link
Member Author

geier commented Oct 11, 2015

@coachshea is working on this and it's nearly finished I believe

Am 11. Oktober 2015 00:37:28 MESZ, schrieb libre-man [email protected]:

This could be done pretty easily by editing the EventColumn.new_event
and EventColumn.edit function to check the config if the user wants to
use an external editor and if so open a template for the event and then
parse the saved text. This would be the same as khard does this. I
would be willing to implement it.


Reply to this email directly or view it on GitHub:
#226 (comment)

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

@dopefishh
Copy link
Contributor

Proposal:

Add to config for the interactive ikhal
editor = which can be khal or system
system would then try several things, sensible-editor, env var EDITOR, vi etc...

Also what would be cool is that if you do khal new and don't specify the minimal argument START and SUMMARY then the program will either start the editor specified in the config or maybe even read from stdin.

Also I'm willing to implement this if we think it's worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants