-
Notifications
You must be signed in to change notification settings - Fork 213
[0.6.0] ImportError #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
the version file should be auto-generated during setup or while creating the package. How did you get and install khal? |
@geier I don't see how since we use setuptools-scm now. |
this line should do the trick 886a354#diff-2eeaed663bd0d25b7e608891384b7298R45 |
I see, it works for me too. @matthiasbeyer could you give us the full output of |
Just guessing here, I think the issue manifests itself if someone uses the release tarballs and not git as in this case setuptools_scm does not find any scm info to build version.py edit: just downloaded the tarball and did:
I don't see any version.py (but neither a reference to setuptools_scm) and running khal results in
|
did you get the release tarballs from github? the official ones from pypi or khal's website should have a |
cc @0-wiz-0 I think this is relevant to vdirsyncer. |
I'm installing through my Packagemanager, which installs khal from this derivation which I updated to khal 0.6.0. I'm the package maintainer of the pkg, I tried to update and ran into the error reported here. |
I used the zipfile from the "download now" button (I know, I know) and there was no version.py file. Same problem as the above. |
The svn copy [r1021] is also missing version.py for tags/v0.6.0. |
The SCM should never contain the version.py file, it gets generated when calling setup.py and gets included in the distribution archives. It does need the As a quick and dirty fix you can just create a file And it looks like setuptools_scm does not support svn (yet?). |
I've switched to using git clone... but you might want to add a README Philip On Tue, Jul 21, 2015 at 10:50:51AM +0100, Christian Geier wrote:
Philip Allen, Executive Chairman, CoreFiling Limited |
I've just introduced a check in |
on a sidenote, unlike mercurial tarballs (which are supported by setuptools_scm) unpacked git tarballs completely lack metadata, (except for guessign from the folder name if one is lucky) since git is so bad at that, i opted for not supporting git tarballs |
@plega yes, I'll put something in the README, and make it print a warning if a svn or github tarball is used (like @untitaker suggested). @RonnyPfannschmidt now that you mention it I remember you ranting about how bad git is in that regard |
@geier the next version of setuptools_scm will properly error out with such occasions (devpi-client did also cause some issues), |
@RonnyPfannschmidt awesome, thanks! |
@matthiasbeyer please change the link in the package to https://pypi.python.org/packages/source/k/khal/khal-${version}.tar.gz |
I'm trying this, hang on. |
Seems to work, thanks a lot. |
Thanks for bringing this to our attention (and for taking care of a package!) |
You're welcome! |
When starting khal version 0.6.0, I get an import error instantly:
The text was updated successfully, but these errors were encountered: