Don't expand events with REC.-ID but no master event #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now we expanded *all* events with a RRULE or RDATE, even if only VEVENTs (with the same UID) with specified RECURRENCE-ID parameters were present. In this case, the expansion is nonsensical, because we do not know the start (and end) datetime of the master (but only of the exceptions). This fixes #323.
|
This isn't the cleanest solution, but it works. |
| @@ -12,7 +12,7 @@ | |||
| logger = log.logger | |||
|
|
|||
|
|
|||
| def expand(vevent, href=''): | |||
| def expand(vevent, href='', expand=True): | |||
There was a problem hiding this comment.
Strongly dislike this, I'd prefer if we could move the entire logic into the expand function.
|
Even with the cleanest solution, I'd prefer not having any of those workarounds in khal, especially as it seems this is a bug in vdirsyncer (and nowhere else) anyway. |
|
@untitaker: did you get any (private) feedback on pimutils/vdirsyncer#391? |
|
No. |
|
Can we close this? |
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now we expanded all events with a RRULE or RDATE, even if only
VEVENTs (with the same UID) with specified RECURRENCE-ID parameters were
present. In this case, the expansion is nonsensical, because we do not
know the start (and end) datetime of the master (but only of the
exceptions).
This fixes #323.