Skip to content

dstart and until should be same type (floating or localized) #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Jul 30, 2021
Merged

dstart and until should be same type (floating or localized) #1061

merged 2 commits into from Jul 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2021

Fix #810

@ghost
Copy link
Author

ghost commented May 30, 2021 •
edited by ghost
Loading

Ticket was written as an issue with new. new/edit should behave similarly. That said, I also looked very closely at the class LocalizedEvent which localizes start and end as needed which comes into play via Event.fromVEvents(). Both import_event and pritnics call Event.fromVEvents().

WhyNotHugo
WhyNotHugo approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@WhyNotHugo
Copy link
Member

Thanks!

@WhyNotHugo WhyNotHugo merged commit ee23103 into pimutils:master Jul 30, 2021
@ghost ghost deleted the fix/810 branch July 31, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

khal new --repeat --until produces invalid VEVENTs
1 participant
@WhyNotHugo