Skip to content

[Ruby] Bugfix for Message.[] for repeated or map fields. #8313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
haberman merged 1 commit into from
Feb 19, 2021
Merged

[Ruby] Bugfix for Message.[] for repeated or map fields. #8313

haberman merged 1 commit into from
Feb 19, 2021

Conversation

@haberman
Copy link
Member

@haberman haberman commented Feb 19, 2021

Fixes: #8311

@google-cla google-cla bot added the cla: yes label Feb 19, 2021
@haberman haberman mentioned this pull request Feb 19, 2021
Closed
@haberman haberman requested a review from acozzette February 19, 2021 17:33
hatstand
hatstand approved these changes Feb 19, 2021
View reviewed changes
Copy link

@hatstand hatstand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 👍

@haberman haberman merged commit 4f961c8 into protocolbuffers:3.15.x Feb 19, 2021
@quartzmo
Copy link

quartzmo commented Feb 19, 2021

Thanks!

This was referenced Mar 7, 2021
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@haberman haberman deleted the ruby-crash-fix branch April 20, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hatstand hatstand hatstand approved these changes

@acozzette acozzette acozzette approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haberman @quartzmo @hatstand @acozzette @protobuf-kokoro