Skip to content

[FreeThreading] test_ssl fails with env_changed: warnings.filters was modified by test_ssl #126483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner opened this issue Nov 6, 2024 · 6 comments
Closed

[FreeThreading] test_ssl fails with env_changed: warnings.filters was modified by test_ssl #126483

vstinner opened this issue Nov 6, 2024 · 6 comments
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes tests Tests in the Lib/test dir topic-free-threading

Comments

@vstinner
Copy link
Member

vstinner commented Nov 6, 2024 •
edited by bedevere-app bot
Loading

On a Free Threaded build, test_ssl fails with:

$ ./python -m test test_ssl --fail-env-changed -m test_ssl_in_multiple_threads 
(...)
Warning -- warnings.filters was modified by test_ssl
Warning --   Before: (2199023321584, [], [])
Warning --   After:  (2199997062288, [('always', None, <class 'ResourceWarning'>, None, 0)], [('always', None, <class 'ResourceWarning'>, None, 0)]) 
test_ssl failed (env changed)
(...)
Result: ENV CHANGED

The problem comes from test_check_hostname_idn() which uses warnings_helper.check_no_resource_warning() (changes warnings filters).

Linked PRs
@vstinner vstinner added tests Tests in the Lib/test dir topic-free-threading labels Nov 6, 2024
@colesbury
Copy link
Contributor

To add to your description: check_no_resource_warning() uses warnings.filterwarnings and warnings.catch_warnings, which are not thread-safe in Python (even with the GIL).

So it's not safe to run test_check_hostname_idn from multiple threads concurrently like test_ssl_in_multiple_threads is doing.

@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
@vstinner
Copy link
Member Author

vstinner commented Apr 2, 2025

cc @nascheme

@kumaraditya303
Copy link
Contributor

Should be fixed now as warnings is thread safe now.

@graingert
Copy link
Contributor

graingert commented Apr 18, 2025 •
edited
Loading

It's safe (and only by default) on the free threaded builds, but not on the regular builds

@graingert graingert reopened this Apr 18, 2025
graingert added a commit to graingert/cpython that referenced this issue Apr 18, 2025
@graingert
pythongh-126483: disable warnings filters mutation in concurrent test…
6a0d82f 
…_check_hostname_idn use by test_ssl_in_multiple_threads
@bedevere-app bedevere-app bot mentioned this issue Apr 18, 2025
Merged
@graingert graingert added 3.13 bugs and security fixes 3.14 bugs and security fixes labels Apr 18, 2025
@graingert
Copy link
Contributor

this also needs fixing on 3.13

colesbury pushed a commit that referenced this issue Jun 4, 2025
@graingert
gh-126483: disable warnings filters mutation in concurrent test (GH-1…
40c8be0 
…32694)

The `test_ssl_in_multiple_threads` test failed because `test_check_hostname_idn()`
modified the global warnings filters via `warnings_helper.check_no_resource_warning()`.
Only check for warnings when the context aware warnings feature is enabled, which makes
the warnings filter context-local and thread-safe.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2025
@graingert @miss-islington
pythongh-126483: disable warnings filters mutation in concurrent test (…
3d216ed 
…pythonGH-132694)

The `test_ssl_in_multiple_threads` test failed because `test_check_hostname_idn()`
modified the global warnings filters via `warnings_helper.check_no_resource_warning()`.
Only check for warnings when the context aware warnings feature is enabled, which makes
the warnings filter context-local and thread-safe.
(cherry picked from commit 40c8be0)

Co-authored-by: Thomas Grainger <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 4, 2025
@graingert @miss-islington
pythongh-126483: disable warnings filters mutation in concurrent test (…
1421ad3 
…pythonGH-132694)

The `test_ssl_in_multiple_threads` test failed because `test_check_hostname_idn()`
modified the global warnings filters via `warnings_helper.check_no_resource_warning()`.
Only check for warnings when the context aware warnings feature is enabled, which makes
the warnings filter context-local and thread-safe.
(cherry picked from commit 40c8be0)

Co-authored-by: Thomas Grainger <[email protected]>
This was referenced Jun 4, 2025
Merged
Merged
colesbury pushed a commit that referenced this issue Jun 4, 2025
@miss-islington @graingert
[3.14] gh-126483: disable warnings filters mutation in concurrent test (
3b01be2 
GH-132694) (GH-135131)

The `test_ssl_in_multiple_threads` test failed because `test_check_hostname_idn()`
modified the global warnings filters via `warnings_helper.check_no_resource_warning()`.
Only check for warnings when the context aware warnings feature is enabled, which makes
the warnings filter context-local and thread-safe.
(cherry picked from commit 40c8be0)

Co-authored-by: Thomas Grainger <[email protected]>
colesbury added a commit that referenced this issue Jun 4, 2025
@miss-islington @graingert @colesbury
[3.13] gh-126483: disable warnings filters mutation in concurrent test (
ae2e795 
GH-132694) (GH-135132)

The `test_ssl_in_multiple_threads` test failed because `test_check_hostname_idn()`
modified the global warnings filters via `warnings_helper.check_no_resource_warning()`.
Disable the warnings check in the multi-threaded test because `warnings_helper` isn't
thread-safe in 3.13 or earlier.
(cherry picked from commit 40c8be0)

Co-authored-by: Thomas Grainger <[email protected]>

* Fix for 3.13

---------

Co-authored-by: Thomas Grainger <[email protected]>
Co-authored-by: Sam Gross <[email protected]>
@colesbury
Copy link
Contributor

Thanks for fixing this @graingert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 bugs and security fixes tests Tests in the Lib/test dir topic-free-threading
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vstinner @graingert @colesbury @kumaraditya303