Skip to content

Unify minimum Shakapacker versions #2225

@alexeyr-ci2

Description

@alexeyr-ci2

We currently have 3 different minimum Shakapacker versions stated:

  1. https://github.com/shakacode/react_on_rails/blob/9df8fd9cedff044d8255a59659394d5c2cf535b4/README.md#prerequisites says 6.0.0
  2. MINIMUM_SHAKAPACKER_VERSION = "6.5.1"
    says 6.5.1 (check_minimum_shakapacker_version seems to explicitly fail with older versions than that)
  3. MINIMUM_SHAKAPACKER_VERSION = "8.2.0"
    tests only with 8.2.0.

They should be the same, probably 6.5.1. Possibly we need to have separate additional tests for 8.2.0 as the minimum supported version for additional features, but it's low priority.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions