-
Notifications
You must be signed in to change notification settings - Fork 29
TypeScript improvements #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It's weird, the project compiles without warning, but it's true that And fill free to make a PR with your improvments ! |
It's because the TS configuration is very lenient atm (check my commits to see how I've made it stricter). |
I've adapted the examples based on what you told me. They still seem to work fine ;-) |
Thanks a lot ! |
Hello there!
I'm interested in contributing a few TypeScript improvements to this project, as I plan on using it for a PoC.
I have already forked the project and made some changes for better type safety: https://github.com/dsebastien/react-sigma-v2/commits/main
One thing that is not clear for me is this: https://github.com/sim51/react-sigma-v2/blob/main/src/index.ts#L21
Can you tell me what
NodeKey
is supposed to be? It's not defined at the moment it seems. For now I've tried usingimport { NodeKey } from "graphology-types";
, which is in factstring | number
, but then I get errors in thecomplete.tsx
example, where the code always expects thehoveredNode
state to be astring
.The text was updated successfully, but these errors were encountered: