Skip to content

allow setSigma to be generic over the graph typ #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kristof-mattei
Copy link
Contributor

@kristof-mattei kristof-mattei commented Feb 19, 2024

Closes #58

@kristof-mattei kristof-mattei changed the title generic set sigma allow setSigma to be generic over the graph typ Feb 19, 2024
@sim51
Copy link
Owner

sim51 commented Feb 20, 2024

Thanks for the PR will check that.

BTW, I'm waiting the release of sigma v3 to make a refacto of this library.
The v3 comes with more generic types (check jacomyal/sigma.js#1359), and I need to handle that also in this lib.

@kristof-mattei
Copy link
Contributor Author

Thanks for the PR will check that.

BTW, I'm waiting the release of sigma v3 to make a refacto of this library. The v3 comes with more generic types (check jacomyal/sigma.js#1359), and I need to handle that also in this lib.

You want me to try merge that one in and see how it works?

@sim51
Copy link
Owner

sim51 commented Feb 26, 2024

It's merged

@sim51 sim51 closed this Feb 26, 2024
@sim51
Copy link
Owner

sim51 commented Feb 26, 2024

You want me to try merge that one in and see how it works?

Thanks a lot, but I will do it. With the next version of sigma, I will do a major release, so I will take advantage of it to make some cleanups and breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref is not generic
2 participants