fix: Keep enum prefix if would be numeric without #1223
Merged
+130
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1222
Currently, if we try to generate typescript with the option
removeEnumPrefixenabled and encounter and enum like:We strip the enum name prefix and generate invalid typescript:
This changes this behavior to strip the enum prefix only if all resulting values are valid, advisable typescript. E.g.
Becomes
This will treat as numeric: