Skip to content

test failure with upcoming ggplot2 release #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonpcouch opened this issue Apr 9, 2025 · 1 comment · Fixed by #550
Closed

test failure with upcoming ggplot2 release #549

simonpcouch opened this issue Apr 9, 2025 · 1 comment · Fixed by #550

Comments

@simonpcouch
Copy link
Collaborator

   ══ Failed tests ════════════════════════════════════════════════════════════════
   ── Failure ('test-shade_p_value.R:157:4'): `shade_p_value()` handles 0-area shading without issue (#528) ──
   Expected `... <- NULL` to run without any conditions.
   i Actually got a <lifecycle_stage> with text:
     is.ggplot() is deprecated
   ── Failure ('test-shade_p_value.R:161:4'): `shade_p_value()` handles 0-area shading without issue (#528) ──
   Expected `print(zero_area_shade)` to run without any conditions.
   i Actually got a <simpleError> with text:
     object 'zero_area_shade' not found
   Backtrace:
       ▆
    1. ├─infer:::expect_doppelganger(...) at test-shade_p_value.R:161:4
    2. │ └─vdiffr::expect_doppelganger(title, fig, ...) at tests/testthat/helper-data.R:5:3
    3. │   └─vdiffr (local) writer(fig, testcase, title)
    4. │     └─vdiffr:::print_plot(plot, title)
    5. └─testthat::expect_no_condition(print(zero_area_shade))

   [ FAIL 2 | WARN 0 | SKIP 109 | PASS 349 ]

Will get this updated and off to CRAN in the coming days.

@simonpcouch simonpcouch linked a pull request Apr 9, 2025 that will close this issue
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant