-
Notifications
You must be signed in to change notification settings - Fork 119
Closed
3 / 43 of 4 issues completedLabels
bugSomething isn't workingSomething isn't working
Description
A user has reported an error they received which comes from not preprocessing enough TLS record in MPC-TLS.
The relevant logic is here:
tlsn/crates/mpc-tls/src/config.rs
Lines 52 to 57 in d8747d4
| let max_sent_records = self | |
| .max_sent_records | |
| .unwrap_or_else(|| MIN_SENT_RECORDS + max_sent.div_ceil(16384)); | |
| let max_recv_records = self | |
| .max_recv_records | |
| .unwrap_or_else(|| MIN_RECV_RECORDS + max_recv_online.div_ceil(16384)); |
Where we assume that the received records will be the maximum TLS record size (16kB). This turns out to not be a safe assumption.
We need to do 2 things:
- Expose the configuration in
tlsn_common::config::ProtocolConfigso that this can be overridden. - Come up with a better estimator.
Sub-issues
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working