Skip to content

Record count estimation is too low #737

@sinui0

Description

@sinui0

A user has reported an error they received which comes from not preprocessing enough TLS record in MPC-TLS.

The relevant logic is here:

let max_sent_records = self
.max_sent_records
.unwrap_or_else(|| MIN_SENT_RECORDS + max_sent.div_ceil(16384));
let max_recv_records = self
.max_recv_records
.unwrap_or_else(|| MIN_RECV_RECORDS + max_recv_online.div_ceil(16384));

Where we assume that the received records will be the maximum TLS record size (16kB). This turns out to not be a safe assumption.

We need to do 2 things:

  1. Expose the configuration in tlsn_common::config::ProtocolConfig so that this can be overridden.
  2. Come up with a better estimator.

Sub-issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions