Skip to content

[ysql] Port table locks tests from privileges.sql to YB #27402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
Tracked by #11571
rthallamko3 opened this issue May 29, 2025 · 0 comments
Closed
1 task done
Tracked by #11571

[ysql] Port table locks tests from privileges.sql to YB #27402

rthallamko3 opened this issue May 29, 2025 · 0 comments
Assignees
Labels
2025.1 Backport Required area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@rthallamko3
Copy link
Contributor

rthallamko3 commented May 29, 2025

Jira Link: DB-16936

Description

Port table locks tests from privileges.sql to YB

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@rthallamko3 rthallamko3 added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels May 29, 2025
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels May 29, 2025
yusong-yan added a commit that referenced this issue May 30, 2025
Summary:
The yb.port.privileges test involves LOCK TABLE statements. Previously, table-level locks were not supported in YugabyteDB, so these statements would fail with:

```
LOCK atest2 IN ACCESS EXCLUSIVE MODE; -- ok
ERROR:  ACCESS EXCLUSIVE not supported yet
LINE 1: LOCK atest2 IN ACCESS EXCLUSIVE MODE;
                       ^
HINT:  Please report the issue on https://github.com/YugaByte/yugabyte-db/issues
```

Now that table-level locking is supported, this diff enables LOCK TABLE functionality for the test and updates the yb.port.privileges.out file to reflect the expected behavior where LOCK TABLE works as intended.
Jira: DB-16936

Test Plan: ./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressPgAuth#schedule'

Reviewers: bkolagani, pjain, rthallam, jason

Reviewed By: bkolagani, rthallam, jason

Subscribers: ybase, rthallam, yql

Differential Revision: https://phorge.dev.yugabyte.com/D44367
@yusong-yan yusong-yan changed the title [ysql] Port table locks tests from create_am.sql, and privileges.sql to YB [ysql] Port table locks tests from privileges.sql to YB May 30, 2025
yusong-yan added a commit that referenced this issue Jun 3, 2025
…leges test

Summary:
Original commit: 3ff5c3b / D44367
The yb.port.privileges test involves LOCK TABLE statements. Previously, table-level locks were not supported in YugabyteDB, so these statements would fail with:

```
LOCK atest2 IN ACCESS EXCLUSIVE MODE; -- ok
ERROR:  ACCESS EXCLUSIVE not supported yet
LINE 1: LOCK atest2 IN ACCESS EXCLUSIVE MODE;
                       ^
HINT:  Please report the issue on https://github.com/YugaByte/yugabyte-db/issues
```

Now that table-level locking is supported, this diff enables LOCK TABLE functionality for the test and updates the yb.port.privileges.out file to reflect the expected behavior where LOCK TABLE works as intended.
Jira: DB-16936

Test Plan: ./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressPgAuth#schedule'

Reviewers: bkolagani, pjain, rthallam, jason, #db-approvers

Reviewed By: rthallam

Subscribers: yql, rthallam, ybase

Differential Revision: https://phorge.dev.yugabyte.com/D44405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025.1 Backport Required area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants