Skip to content

[YSQL] YSQL: Remove obsolete YB_TODOs in pg_dump.c #27423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
fizaaluthra opened this issue May 29, 2025 · 0 comments
Open
1 task done

[YSQL] YSQL: Remove obsolete YB_TODOs in pg_dump.c #27423

fizaaluthra opened this issue May 29, 2025 · 0 comments
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@fizaaluthra
Copy link
Member

fizaaluthra commented May 29, 2025 •
edited by jira bot
Loading

Jira Link: DB-16963

Description

Remove obsolete YB_TODOs in pg_dump.c.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@fizaaluthra fizaaluthra added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels May 29, 2025
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels May 29, 2025
fizaaluthra added a commit that referenced this issue May 30, 2025
@fizaaluthra
[#27423] YSQL: Remove obsolete YB_TODOs in pg_dump.c
e106e7d 
Summary:
Remove obsolete YB_TODOs in pg_dump.c.

YB commit 9fba95f introduced dopt->include_yb_metadata in calls to buildACLQueries to retrieve initial privileges for extension objects, enabling them to be included in ysql_dump for backup/restore.

Upstream PostgreSQL commit 0c9d84427f441602425b0e18be5cfe751d1d8ebe refactored ACL handling and removed buildACLQueries. Initial privileges are now always retrieved in getAdditionalACLs and emitted conditionally in dumpACL.

YB PG15 commit 2e57f19 reintroduced the include_yb_metadata logic in dumpACL to preserve the YB behavior.

As the intended functionality is now present, these YB_TODOs are no longer necessary and can be removed.
Jira: DB-16963

Test Plan: Jenkins

Reviewers: yguan

Reviewed By: yguan

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D44366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @fizaaluthra