Details
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Branch
- default
Event Timeline
Code analysis found 5 defects in diff 737815:
- 1 defect found by clang-format
- 1 defect found by clang-tidy
- 3 defects found by clang-format (Mozlint)
You can run this analysis locally with:
- ./mach static-analysis check --outgoing (C/C++)
- ./mach lint --warnings --outgoing
- ./mach clang-format -p dom/security/nsCSPParser.cpp
For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 737815.
Code analysis found 1 defect in diff 741433:
- 1 defect found by clang-tidy
1 defect unresolved and 4 defects closed compared to the previous diff 738662.
You can run this analysis locally with:
- ./mach static-analysis check --outgoing (C/C++)
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 741433.
| dom/security/nsCSPContext.cpp | ||
|---|---|---|
| 654–663 | Good question. We fail /content-security-policy/script-src/script-src-strict_dynamic_meta_tag.html and /content-security-policy/script-src/script-src-strict_dynamic_non_parser_inserted.html with
| |
| dom/security/nsCSPUtils.cpp | ||
| 1163 | No, because we still need to collect all hashes in the directive even after find an instance of 'strict-dynamic'. | |