Page MenuHomePhabricator
Differential D193676

Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r?#dom-core
ClosedPublic
Actions

Authored by avandolder on Nov 15 2023, 4:08 PM.
Tags
Referenced Files
Unknown Object (File)
Oct 16 2025, 7:08 AM
Unknown Object (File)
Oct 15 2025, 3:09 PM
Unknown Object (File)
Oct 15 2025, 2:17 PM
Unknown Object (File)
Oct 15 2025, 11:25 AM
Unknown Object (File)
Oct 15 2025, 9:36 AM
Unknown Object (File)
Oct 15 2025, 7:20 AM
Unknown Object (File)
Oct 15 2025, 6:29 AM
Unknown Object (File)
Oct 15 2025, 5:06 AM
View All 52 Files
Subscribers
hsivonen
reviewbot

Details

Reviewers
hsivonen
Group Reviewers
dom-core
webidl
Commits
rMOZILLACENTRAL2587aec125b6: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core…
rMOZILLACENTRAL3a35e1401130: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core…
rMOZILLACENTRAL6f50077df42a: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core…
rMOZILLACENTRAL4d2749962c5f: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core…
rMOZILLACENTRAL98dd5766dd46: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core…
Bugzilla Bug ID
1712140

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default

Event Timeline

avandolder created this revision.Nov 15 2023, 4:08 PM
Herald added a project: secure-revision. · View Herald TranscriptNov 15 2023, 4:08 PM
Harbormaster completed remote builds in B597102: Diff 787203.Nov 15 2023, 4:08 PM
avandolder added a child revision: D193677: Bug 1712140 - Part 6: Unblock Declarative ShadowDOM tests. r?#dom-core.Nov 15 2023, 4:08 PM
phab-bot published this revision for review.Nov 15 2023, 4:09 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a reviewer: webidl. · View Herald TranscriptNov 15 2023, 4:09 PM
avandolder updated this revision to Diff 788176.Nov 17 2023, 8:46 PM
avandolder edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B597954: Diff 788176.Nov 17 2023, 8:46 PM
hsivonen accepted this revision.Nov 21 2023, 12:09 PM
hsivonen added a project: testing-exception-elsewhere (Please comment explaining where the tests are).
hsivonen added a subscriber: hsivonen.

testing-exception-elsewhere: Testing in https://phabricator.services.mozilla.com/D193677

dom/base/Document.cpp
19020

I believe this, but where does the spec say the URL is about:blank?

This revision is now accepted and ready to land.Nov 21 2023, 12:09 PM
avandolder added inline comments.Nov 21 2023, 8:30 PM
dom/base/Document.cpp
19020

It's stated in the non-normative description of the function under https://html.spec.whatwg.org/#unsafe-html-parsing-methods.

I found the discussion about this from the spec PR, and it looks like about:blank was agreed upon, but they forgot to add it to the method steps and not just the description.

avandolder updated this revision to Diff 789560.Nov 21 2023, 8:49 PM
Harbormaster completed remote builds in B599139: Diff 789560.Nov 21 2023, 8:49 PM
avandolder updated this revision to Diff 789686.Nov 22 2023, 4:49 AM
Harbormaster completed remote builds in B599234: Diff 789686.Nov 22 2023, 4:50 AM
reviewbot added a subscriber: reviewbot.Nov 22 2023, 5:23 AM

Code analysis found 2 defects in diff 789686:

  • 2 build errors found by clang-tidy
IMPORTANT: Found 2 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 789686.

avandolder updated this revision to Diff 790638.Nov 23 2023, 10:48 PM
Harbormaster completed remote builds in B600050: Diff 790638.Nov 23 2023, 10:48 PM
reviewbot added a comment.Nov 23 2023, 11:13 PM

2 defects closed compared to the previous diff 789686.

If you see a problem in this automated review, please report it here.

avandolder updated this revision to Diff 790672.Nov 23 2023, 11:24 PM
Harbormaster completed remote builds in B600083: Diff 790672.Nov 23 2023, 11:24 PM
avandolder updated this revision to Diff 790882.Nov 24 2023, 2:42 PM
Harbormaster completed remote builds in B600271: Diff 790882.Nov 24 2023, 2:42 PM
avandolder updated this revision to Diff 791776.Nov 28 2023, 6:49 AM
Harbormaster completed remote builds in B600959: Diff 791776.Nov 28 2023, 6:49 AM
avandolder added a child revision: D194846: Bug 1712140 - Part 5: Block Declarative ShadowDOM behind feature pref. r?emilio,#dom-core.Nov 28 2023, 6:49 AM
avandolder updated this revision to Diff 792947.Nov 30 2023, 7:27 AM
Harbormaster completed remote builds in B601925: Diff 792947.Nov 30 2023, 7:27 AM
avandolder updated this revision to Diff 793275.Nov 30 2023, 6:34 PM
Harbormaster completed remote builds in B602213: Diff 793275.Nov 30 2023, 6:34 PM
avandolder removed a child revision: D193677: Bug 1712140 - Part 6: Unblock Declarative ShadowDOM tests. r?#dom-core.Nov 30 2023, 6:40 PM
Closed by commit rMOZILLACENTRAL98dd5766dd46: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core… (authored by avandolder). · Explain WhyNov 30 2023, 11:23 PM
This revision was automatically updated to reflect the committed changes.
avandolder added a commit: rMOZILLACENTRAL98dd5766dd46: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core….
sstanca reopened this revision.Dec 1 2023, 1:55 AM
This revision is now accepted and ready to land.Dec 1 2023, 1:55 AM
sstanca added a reverting change: rMOZILLACENTRAL74885f12c47d: Backed out 6 changesets (bug 1712140) for causing wpt failures in declarative….Dec 1 2023, 1:55 AM
avandolder updated this revision to Diff 793588.Dec 1 2023, 6:46 AM
Harbormaster completed remote builds in B602472: Diff 793588.Dec 1 2023, 6:46 AM
avandolder updated this revision to Diff 793848.Dec 1 2023, 3:02 PM
Harbormaster completed remote builds in B602743: Diff 793848.Dec 1 2023, 3:02 PM
avandolder updated this revision to Diff 794700.Dec 4 2023, 4:15 PM
Harbormaster completed remote builds in B603463: Diff 794700.Dec 4 2023, 4:15 PM
Closed by commit rMOZILLACENTRAL4d2749962c5f: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core… (authored by avandolder). · Explain WhyDec 4 2023, 5:44 PM
This revision was automatically updated to reflect the committed changes.
avandolder added a commit: rMOZILLACENTRAL4d2749962c5f: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core….
imoraru reopened this revision.Dec 4 2023, 8:49 PM
This revision is now accepted and ready to land.Dec 4 2023, 8:49 PM
imoraru added a reverting change: rMOZILLACENTRALeb4f17d8d3ea: Backed out 6 changesets (bug 1712140) for causing wpt failures on declarative….Dec 4 2023, 8:49 PM
avandolder updated this revision to Diff 795312.Dec 5 2023, 4:50 PM
Harbormaster completed remote builds in B603995: Diff 795312.Dec 5 2023, 4:50 PM
Closed by commit rMOZILLACENTRAL6f50077df42a: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core… (authored by avandolder). · Explain WhyDec 5 2023, 6:55 PM
This revision was automatically updated to reflect the committed changes.
avandolder added a commit: rMOZILLACENTRAL6f50077df42a: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core….
sstanca reopened this revision.Dec 5 2023, 10:22 PM
This revision is now accepted and ready to land.Dec 5 2023, 10:22 PM
sstanca added a reverting change: rMOZILLACENTRALc6c4a3b054ee: Backed out 6 changesets (bug 1712140) for causing Linux related wpt failures in….Dec 5 2023, 10:22 PM
avandolder updated this revision to Diff 795985.Dec 6 2023, 6:02 PM
Harbormaster completed remote builds in B604569: Diff 795985.Dec 6 2023, 6:02 PM
Closed by commit rMOZILLACENTRAL3a35e1401130: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core… (authored by avandolder). · Explain WhyDec 6 2023, 10:57 PM
This revision was automatically updated to reflect the committed changes.
avandolder added a commit: rMOZILLACENTRAL3a35e1401130: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core….
imoraru reopened this revision.Dec 7 2023, 6:27 AM
This revision is now accepted and ready to land.Dec 7 2023, 6:27 AM
imoraru added a reverting change: rMOZILLACENTRAL6bd9b7d691bc: Backed out 6 changesets (bug 1712140) for causing sanitizer failures on….Dec 7 2023, 6:27 AM
imoraru added a reverting change: rMOZILLACENTRALd6000f1e4ebb: Backed out 6 changesets (bug 1712140) for causing sanitizer failures on….Dec 7 2023, 9:50 AM
avandolder updated this revision to Diff 796567.Dec 7 2023, 3:27 PM
Harbormaster completed remote builds in B605027: Diff 796567.Dec 7 2023, 3:27 PM
Closed by commit rMOZILLACENTRAL2587aec125b6: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core… (authored by avandolder). · Explain WhyDec 8 2023, 12:55 AM
This revision was automatically updated to reflect the committed changes.
avandolder added a commit: rMOZILLACENTRAL2587aec125b6: Bug 1712140 - Part 4: Add parseHTMLUnsafe and setHTMLUnsafe methods. r=dom-core….
Harbormaster completed remote builds in B605541: Diff 796875.Jan 2 2024, 2:50 PM

Revision Contents
Changeset List

PathSize
dom/
base/
3 lines
27 lines
3 lines
4 lines
3 lines
5 lines
html/
3 lines
5 lines
webidl/
2 lines
4 lines
4 lines

Diff 796567

View Options

dom/base/Document.h

Loading...
View Options

dom/base/Document.cpp

Loading...
View Options

dom/base/Element.h

Loading...
View Options

dom/base/Element.cpp

Loading...
View Options

dom/base/ShadowRoot.h

Loading...
View Options

dom/base/ShadowRoot.cpp

Loading...
View Options

dom/html/HTMLTemplateElement.h

Loading...
View Options

dom/html/HTMLTemplateElement.cpp

Loading...
View Options

dom/webidl/Document.webidl

Loading...
View Options

dom/webidl/Element.webidl

Loading...
View Options

dom/webidl/ShadowRoot.webidl

Loading...
Privacy · Cookies · Legal