Nice test addition for this!

Just a quick drive by for consideration now or later: Petru just added a new Store API via the D271420 patch stack which might be of us here instead of having a manual rehydration of complex dependencies

just a drive by. I'll defer the full review to @boek or @matt-tighe

Nothing blocking from me; just some nits and suggestions for enhancements.

I'm seeing a weird UX glitch/blip. When when going from Private -> Light theme, there is a noticeable UI color flip as it transitions from Private to Light. It's looking like potentially a bug with the CenterAlignedTopAppBar Composable we use in the Tab Page Banner. Could we look into this before landing? It looks like this bug is present on Main, but it's more noticeable on this patch on my 34 emulator

FYI, I'm having issues pulling down this stack locally. Based on the error output, I think think this particular patch has a merge conflict with SupportUtils

From some cursory reads, the CustomPlacementPopup largely looks like our DropdownMenu Composable, since it seems like a lot of the callsites are not actually "customizing" the pop-up

I'm not sure this composable adds much value beyond the tap sound, but we can keep this stack rolling

If the design aligns with a reusable Card component, can we file a ticket to implement this reusable component in code?

testing exception: API refactor. verified locally

The pickers look great! It looks like we have some real failures in the UI tests for Fenix & Focus though

Thanks for the great clean up here!

This fix will be good enough until Settings has a redesign + Compose migration

Nothing blocking from me; just some optional nits/suggestions! Thanks for handling this! We're one step closer to being able to migrate the Tabs Tray to 100% redux

Just a few nits, but let's land this when the CI is green 🚢

I'll be getting back to this stack tomorrow hopefully, but we have a new bottom sheet handle we may need to update

https://treeherder.mozilla.org/jobs?repo=try&revision=a1da4d5b698f1cbb230aa12b608122fc3f10bff3

Nothing super major blocking this for me, but marking this as request changes to take off of the review queue

tagging in @delphine to re-review the string

this has already landed over in D270240

Most recent push