Page MenuHomePhabricator
People TYLin

TYLin (Ting-Yu Lin)
User

Projects

User Details

User Since
Oct 11 2017, 9:39 AM (422 w, 21 h)
Availability
Available
Review Queue
1

Recent Activity
View All

Today

TYLin added inline comments to D272402: Bug 1994083 Part 6 - Adjust existing WPT expectations. r?dholbert.
Thu, Nov 13, 7:33 AM
TYLin added a comment to D272400: Bug 1994083 Part 4 - Allow AbsoluteContainingBlock to reflow all abspos continuations. r?dholbert.

Try result of the patch stack:

Thu, Nov 13, 7:27 AM
TYLin created D272403: Bug 1994083 Part 7 - Add WPTs for abspos fragmentation in vertical-rl writing-mode. r?dholbert.
Thu, Nov 13, 7:11 AM
TYLin created D272402: Bug 1994083 Part 6 - Adjust existing WPT expectations. r?dholbert.
Thu, Nov 13, 7:11 AM
TYLin created D272401: Bug 1994083 Part 5 - Generate display items for frames in absolute child list. r?dholbert.
Thu, Nov 13, 7:11 AM
TYLin created D272400: Bug 1994083 Part 4 - Allow AbsoluteContainingBlock to reflow all abspos continuations. r?dholbert.
Thu, Nov 13, 7:11 AM
TYLin created D272399: Bug 1994083 Part 3 - Move nsSplittableFrame::PreReflowBlockLevelLogicalSkipSides() to public. r?dholbert.
Thu, Nov 13, 7:11 AM
TYLin created D272398: Bug 1994083 Part 2 - Reduce indent level for the code that reflows abspos children in grid container. r?dholbert.
Thu, Nov 13, 7:11 AM
TYLin created D272397: Bug 1994083 Part 1 - Change aDelegatingFrame type to nsContainerFrame* for ReflowAbsoluteFrame(). r?dholbert.
Thu, Nov 13, 7:11 AM

Yesterday

TYLin closed D271734: Bug 1998869 - Improve noisy reflow log..

This patch has been landed.

Wed, Nov 12, 12:34 AM · testing-exception-unchanged (Doesn't change behavior for users)

Tue, Nov 11

TYLin closed D272075: Bug 1999366 - Use block frame's writing-mode to construct absolute containing block rect. r?#layout.
Tue, Nov 11, 6:05 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin committed rFIREFOXAUTOLAND834918e43e38: Bug 1999366 - Use block frame's writing-mode to construct absolute containing… (authored by TYLin).
Bug 1999366 - Use block frame's writing-mode to construct absolute containing…
Tue, Nov 11, 6:05 PM

Mon, Nov 10

TYLin closed D271736: Bug 1998869 - Remove unused nsBlockFrame::kReflowCommandType..
Mon, Nov 10, 9:29 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin committed rFIREFOXAUTOLAND315371a4b053: Bug 1998869 - Remove unused nsBlockFrame::kReflowCommandType. r=layout… (authored by TYLin).
Bug 1998869 - Remove unused nsBlockFrame::kReflowCommandType. r=layout…
Mon, Nov 10, 9:29 PM
TYLin closed D271735: Bug 1998869 - Remove unused debug flag NOISY_COMBINED_AREA..
Mon, Nov 10, 9:29 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin committed rFIREFOXAUTOLAND8b967346ddd0: Bug 1998869 - Remove unused debug flag NOISY_COMBINED_AREA. r=layout-reviewers… (authored by TYLin).
Bug 1998869 - Remove unused debug flag NOISY_COMBINED_AREA. r=layout-reviewers…
Mon, Nov 10, 9:29 PM
TYLin created D272075: Bug 1999366 - Use block frame's writing-mode to construct absolute containing block rect. r?#layout.
Mon, Nov 10, 8:03 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin updated the diff for D271734: Bug 1998869 - Improve noisy reflow log..

Added a colon to improve the log.

Mon, Nov 10, 7:35 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin added inline comments to D271734: Bug 1998869 - Improve noisy reflow log..
Mon, Nov 10, 7:20 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin added a comment to D271734: Bug 1998869 - Improve noisy reflow log..

To see this log, execute:

Mon, Nov 10, 6:19 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin updated the diff for D271736: Bug 1998869 - Remove unused nsBlockFrame::kReflowCommandType..

Rebased

Mon, Nov 10, 6:17 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin updated the diff for D271735: Bug 1998869 - Remove unused debug flag NOISY_COMBINED_AREA..

Rebased

Mon, Nov 10, 6:17 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin updated the diff for D271734: Bug 1998869 - Improve noisy reflow log..

Rebased

Mon, Nov 10, 6:17 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin committed rFIREFOXBETAe7545a3c99fc: Bug 1997502 - Simplify two nsBlockFrame methods that remove frames. r=layout… (authored by TYLin).
Bug 1997502 - Simplify two nsBlockFrame methods that remove frames. r=layout…
Mon, Nov 10, 3:15 PM
TYLin committed rFIREFOXBETA970c575eb943: Bug 1996677 Part 4 - Fix a potential writing-mode misuse when initializing… (authored by TYLin).
Bug 1996677 Part 4 - Fix a potential writing-mode misuse when initializing…
Mon, Nov 10, 3:02 PM
TYLin committed rFIREFOXBETAa90f35c48d2f: Bug 1996677 Part 1 - Simplify computed size calculation in ReflowInput… (authored by TYLin).
Bug 1996677 Part 1 - Simplify computed size calculation in ReflowInput…
Mon, Nov 10, 3:02 PM
TYLin committed rFIREFOXBETAf50fd6ca170f: Bug 1996677 Part 2 - Change the containing block size parameter to use absCB's… (authored by TYLin).
Bug 1996677 Part 2 - Change the containing block size parameter to use absCB's…
Mon, Nov 10, 3:02 PM
TYLin committed rFIREFOXBETAe79fdbf7b43d: Bug 1996677 Part 3 - Remove logicalCBSizeOuterWM in ReflowAbsoluteFrame(). (authored by TYLin).
Bug 1996677 Part 3 - Remove logicalCBSizeOuterWM in ReflowAbsoluteFrame().
Mon, Nov 10, 3:02 PM
TYLin committed rFIREFOXBETAe44da5448463: Bug 1996146 Part 5 - Move two abspos reflow methods from nsIFrame to… (authored by TYLin).
Bug 1996146 Part 5 - Move two abspos reflow methods from nsIFrame to…
Mon, Nov 10, 2:53 PM
TYLin committed rFIREFOXBETA99972bee1bec: Bug 1996146 Part 3 - Remove ClearAllPositionedTableParts() declaration that is… (authored by TYLin).
Bug 1996146 Part 3 - Remove ClearAllPositionedTableParts() declaration that is…
Mon, Nov 10, 2:53 PM
TYLin committed rFIREFOXBETA2fe4a381eb1d: Bug 1996146 Part 4 - Store positioned table parts using nsContainerFrame… (authored by TYLin).
Bug 1996146 Part 4 - Store positioned table parts using nsContainerFrame…
Mon, Nov 10, 2:53 PM
TYLin committed rFIREFOXBETA35f00baf956d: Bug 1996146 Part 2 - Rename FrameChildListID::Bullet to FrameChildListID… (authored by TYLin).
Bug 1996146 Part 2 - Rename FrameChildListID::Bullet to FrameChildListID…
Mon, Nov 10, 2:53 PM
TYLin committed rFIREFOXBETA8980dc11ee10: Bug 1996146 Part 1 - Remove unused AbsoluteContainingBlock::AppendChildList(). (authored by TYLin).
Bug 1996146 Part 1 - Remove unused AbsoluteContainingBlock::AppendChildList().
Mon, Nov 10, 2:53 PM
TYLin committed rFIREFOXBETA06ee928e276b: Bug 1994235 - Increase fuzzy tolerance for box-decoration-break-border-image. (authored by TYLin).
Bug 1994235 - Increase fuzzy tolerance for box-decoration-break-border-image.
Mon, Nov 10, 2:29 PM
TYLin committed rFIREFOXBETA9a6db133a950: Bug 1981086 - Ship CSS text-autospace. r=layout-jp-market-reviewers,jfkthame (authored by TYLin).
Bug 1981086 - Ship CSS text-autospace. r=layout-jp-market-reviewers,jfkthame
Mon, Nov 10, 2:04 PM
TYLin committed rFIREFOXBETAc098d04ec19e: Bug 1987997 - Change initial value of text-autospace from normal to no… (authored by TYLin).
Bug 1987997 - Change initial value of text-autospace from normal to no…
Mon, Nov 10, 2:01 PM
TYLin committed rFIREFOXBETAf36ac04143f4: Bug 1983345 Part 9 - Remove ViewportFrame::AdjustReflowInputAsContainingBlock(). (authored by TYLin).
Bug 1983345 Part 9 - Remove ViewportFrame::AdjustReflowInputAsContainingBlock().
Mon, Nov 10, 1:54 PM
TYLin committed rFIREFOXBETA1c62271c70f3: Bug 1983345 Part 8 - Remove viewport ReflowInput adjustment in… (authored by TYLin).
Bug 1983345 Part 8 - Remove viewport ReflowInput adjustment in…
Mon, Nov 10, 1:54 PM
TYLin committed rFIREFOXBETAd77d42c8dec1: Bug 1983345 Part 6 - Revise the computation of containing block border-box size. (authored by TYLin).
Bug 1983345 Part 6 - Revise the computation of containing block border-box size.
Mon, Nov 10, 1:54 PM
TYLin committed rFIREFOXBETA95039bc0c5e0: Bug 1983345 Part 7 - Remove the redundant zero-initialization for… (authored by TYLin).
Bug 1983345 Part 7 - Remove the redundant zero-initialization for…
Mon, Nov 10, 1:54 PM
TYLin committed rFIREFOXBETA8c8ff2473836: Bug 1983345 Part 5 - Rename variables in ReflowInput… (authored by TYLin).
Bug 1983345 Part 5 - Rename variables in ReflowInput…
Mon, Nov 10, 1:54 PM
TYLin committed rFIREFOXBETA543139346be9: Bug 1983345 Part 4 - Move a comment next to the check for a replaced element… (authored by TYLin).
Bug 1983345 Part 4 - Move a comment next to the check for a replaced element…
Mon, Nov 10, 1:54 PM
TYLin committed rFIREFOXBETAe09fd0f1ac0b: Bug 1983345 Part 2 - Remove obsolete comment for ReflowAbsoluteFrame(). (authored by TYLin).
Bug 1983345 Part 2 - Remove obsolete comment for ReflowAbsoluteFrame().
Mon, Nov 10, 1:54 PM
TYLin committed rFIREFOXBETAd8930777738b: Bug 1983345 Part 3 - Improve the helper for getting containing block of a… (authored by TYLin).
Bug 1983345 Part 3 - Improve the helper for getting containing block of a…
Mon, Nov 10, 1:54 PM
TYLin committed rFIREFOXBETAd49b89c74309: Bug 1983345 Part 1 - Fix a typo in the documentation for… (authored by TYLin).
Bug 1983345 Part 1 - Fix a typo in the documentation for…
Mon, Nov 10, 1:54 PM

Fri, Nov 7

TYLin created D271736: Bug 1998869 - Remove unused nsBlockFrame::kReflowCommandType..
Fri, Nov 7, 6:11 AM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin created D271735: Bug 1998869 - Remove unused debug flag NOISY_COMBINED_AREA..
Fri, Nov 7, 6:05 AM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin created D271734: Bug 1998869 - Improve noisy reflow log..
Fri, Nov 7, 6:05 AM · testing-exception-unchanged (Doesn't change behavior for users)

Wed, Nov 5

TYLin requested changes to D271277: Bug 1900302 - Removed font.size.inflation.disabledInMasterProcess pref.r?gregp!.

Removing the pref declaration is not enough, we should remove the usage as well. For example, mFontSizeInflationDisabledInMasterProcess in PresShell.
https://searchfox.org/firefox-main/rev/cb52781342cc905eda923d009fc0b678f3a8c8c6/layout/base/PresShell.cpp#912-913

Wed, Nov 5, 7:12 PM · testing-exception-unchanged (Doesn't change behavior for users)

Tue, Nov 4

TYLin added inline comments to D271231: Bug 1996832: Check margin rect of abspos frame for overflowing. r=#anchor-pos.
Tue, Nov 4, 8:02 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin added inline comments to D271230: Bug 1996832: Pass in border-offset padding rect for abspos cb computation. r=#anchor-pos.
Tue, Nov 4, 6:17 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

Mon, Nov 3

TYLin committed rFIREFOXRELEASE4c56aa50ce98: Bug 1992804 Part 4 - Delete unused logic that computes CB size for abspos in… (authored by TYLin).
Bug 1992804 Part 4 - Delete unused logic that computes CB size for abspos in…
Mon, Nov 3, 11:29 AM
TYLin committed rFIREFOXRELEASEd9349b6842bc: Bug 1992804 Part 1 - Simplify callers with IsAbsolutelyPositioned() helper. (authored by TYLin).
Bug 1992804 Part 1 - Simplify callers with IsAbsolutelyPositioned() helper.
Mon, Nov 3, 11:29 AM
TYLin committed rFIREFOXRELEASE1e37b32b03ad: Bug 1992804 Part 2 - Remove unnecessary inline-size == -1 check in… (authored by TYLin).
Bug 1992804 Part 2 - Remove unnecessary inline-size == -1 check in…
Mon, Nov 3, 11:29 AM
TYLin committed rFIREFOXRELEASEa17f266b6587: Bug 1992804 Part 3 - Improve paramaters and documentation for… (authored by TYLin).
Bug 1992804 Part 3 - Improve paramaters and documentation for…
Mon, Nov 3, 11:29 AM
TYLin committed rFIREFOXRELEASE92cf2b2fec55: Bug 1981300 - Remove layout.css.grid-flex-spanning-items-intrinsic-sizing. (authored by TYLin).
Bug 1981300 - Remove layout.css.grid-flex-spanning-items-intrinsic-sizing.
Mon, Nov 3, 11:12 AM
TYLin committed rFIREFOXRELEASE63fc322b2400: Bug 1990170 - Don't clamp max-block-size for bSizeForResolvingRowSizes when re… (authored by TYLin).
Bug 1990170 - Don't clamp max-block-size for bSizeForResolvingRowSizes when re…
Mon, Nov 3, 11:12 AM
TYLin committed rFIREFOXRELEASE732d9b01cfe1: Bug 1991352 Part 5 - Use range-based for-loop to iterate abspos children. (authored by TYLin).
Bug 1991352 Part 5 - Use range-based for-loop to iterate abspos children.
Mon, Nov 3, 10:58 AM
TYLin committed rFIREFOXRELEASEa8df54d157a6: Bug 1991352 Part 3 - Rename nsAbsoluteContainingBlock.{h,cpp} to… (authored by TYLin).
Bug 1991352 Part 3 - Rename nsAbsoluteContainingBlock.{h,cpp} to…
Mon, Nov 3, 10:58 AM
TYLin committed rFIREFOXRELEASEcf64b6be1f7b: Bug 1991352 Part 4 - Rename AbsPosReflowFlag::ConstrainHeight to… (authored by TYLin).
Bug 1991352 Part 4 - Rename AbsPosReflowFlag::ConstrainHeight to…
Mon, Nov 3, 10:58 AM
TYLin committed rFIREFOXRELEASEca88488080c9: Bug 1991352 Part 2 - Rename nsAbsoluteContainingBlock to mozilla… (authored by TYLin).
Bug 1991352 Part 2 - Rename nsAbsoluteContainingBlock to mozilla…
Mon, Nov 3, 10:58 AM
TYLin committed rFIREFOXRELEASEa99f189eb3d0: Bug 1991352 Part 1 - Change AbsPosReflowFlags to an EnumSet. r=layout-reviewers… (authored by TYLin).
Bug 1991352 Part 1 - Change AbsPosReflowFlags to an EnumSet. r=layout-reviewers…
Mon, Nov 3, 10:58 AM
TYLin committed rFIREFOXRELEASEa1df13174491: Bug 1990319 - Prevent gfxSkipCharsIterator from traversing past the start of… (authored by TYLin).
Bug 1990319 - Prevent gfxSkipCharsIterator from traversing past the start of…
Mon, Nov 3, 10:41 AM
TYLin committed rFIREFOXRELEASE1a1d4462e4e4: Bug 1988596 - Enable layout.css.text-autospace.enabled on Nightly. r=jfkthame… (authored by TYLin).
Bug 1988596 - Enable layout.css.text-autospace.enabled on Nightly. r=jfkthame…
Mon, Nov 3, 10:32 AM
TYLin committed rFIREFOXRELEASE7380fbe57e1f: Bug 1989851 Part 3 - Run text-autospace for 1-byte text only at the start of… (authored by TYLin).
Bug 1989851 Part 3 - Run text-autospace for 1-byte text only at the start of…
Mon, Nov 3, 10:30 AM
TYLin committed rFIREFOXRELEASEac8e030f7c7c: Bug 1989851 Part 2 - Check mWordSpacing before calling IsCSSWordSpacingSpace(). (authored by TYLin).
Bug 1989851 Part 2 - Check mWordSpacing before calling IsCSSWordSpacingSpace().
Mon, Nov 3, 10:30 AM
TYLin committed rFIREFOXRELEASEeafe10d94e80: Bug 1989851 Part 1 - Avoid unnecessary findPrecedingClass() calls. r=jfkthame… (authored by TYLin).
Bug 1989851 Part 1 - Avoid unnecessary findPrecedingClass() calls. r=jfkthame…
Mon, Nov 3, 10:30 AM
TYLin committed rFIREFOXRELEASE2ad9aca84207: Bug 1984766 - Replace BoolToYesNo with mozilla::YesOrNo. r=layout-reviewers,hiro (authored by TYLin).
Bug 1984766 - Replace BoolToYesNo with mozilla::YesOrNo. r=layout-reviewers,hiro
Mon, Nov 3, 10:28 AM
TYLin committed rFIREFOXRELEASE2e8c24ad88b2: Bug 1989128 - Optimize GetCharClass() and IsIdeograph() in TextAutospace. (authored by TYLin).
Bug 1989128 - Optimize GetCharClass() and IsIdeograph() in TextAutospace.
Mon, Nov 3, 10:21 AM
TYLin committed rFIREFOXRELEASEaa0e947d307b: Bug 1989117 - Provide a const GetClosestFrameOfType() overload. r=layout… (authored by TYLin).
Bug 1989117 - Provide a const GetClosestFrameOfType() overload. r=layout…
Mon, Nov 3, 10:21 AM
TYLin committed rFIREFOXRELEASEc3c8449fffc0: Bug 1988596 - Enable layout.css.text-autospace.enabled on Nightly. r=jfkthame… (authored by TYLin).
Bug 1988596 - Enable layout.css.text-autospace.enabled on Nightly. r=jfkthame…
Mon, Nov 3, 10:12 AM
TYLin committed rFIREFOXRELEASE8e61ba3fb481: Bug 1989030 - patch 4 - Don't allow text-autospace to be applied in masked… (authored by jfkthame).
Bug 1989030 - patch 4 - Don't allow text-autospace to be applied in masked…
Mon, Nov 3, 10:12 AM
TYLin committed rFIREFOXRELEASEea60a1dcb341: Bug 1989030 - patch 5 - Check that userData is present before trying to access… (authored by jfkthame).
Bug 1989030 - patch 5 - Check that userData is present before trying to access…
Mon, Nov 3, 10:12 AM
TYLin committed rFIREFOXRELEASE22c087686700: Bug 1989030 - patch 3 - Explicitly disable text-autospace for segment-break… (authored by jfkthame).
Bug 1989030 - patch 3 - Explicitly disable text-autospace for segment-break…
Mon, Nov 3, 10:12 AM
TYLin committed rFIREFOXRELEASE672d80c2c966: Bug 1989030 - patch 1 - Check for empty textframe in… (authored by jfkthame).
Bug 1989030 - patch 1 - Check for empty textframe in…
Mon, Nov 3, 10:12 AM
TYLin committed rFIREFOXRELEASE3bf98c592ad3: Bug 1989030 - patch 2 - Don't insert autospace when text frame has text… (authored by TYLin).
Bug 1989030 - patch 2 - Don't insert autospace when text frame has text…
Mon, Nov 3, 10:12 AM
TYLin committed rFIREFOXRELEASE3501390146ed: Bug 1989131 - Update WritingMode::IsVertical() comment to include sideways-*… (authored by TYLin).
Bug 1989131 - Update WritingMode::IsVertical() comment to include sideways-*…
Mon, Nov 3, 10:11 AM
TYLin committed rFIREFOXRELEASE0ca8215bfd96: Bug 1986837 - patch 8 - Defer initialization of prevClass until we know whether… (authored by jfkthame).
Bug 1986837 - patch 8 - Defer initialization of prevClass until we know whether…
Mon, Nov 3, 10:06 AM
TYLin committed rFIREFOXRELEASEbd1a74dfed28: Bug 1986837 - patch 6 - Additional text-autospace testcases. r=jfkthame (authored by jfkthame).
Bug 1986837 - patch 6 - Additional text-autospace testcases. r=jfkthame
Mon, Nov 3, 10:06 AM
TYLin committed rFIREFOXRELEASE21153c0053e2: Bug 1986837 - patch 7 - Properly check for vertical-upright mode in prevClass… (authored by jfkthame).
Bug 1986837 - patch 7 - Properly check for vertical-upright mode in prevClass…
Mon, Nov 3, 10:06 AM
TYLin committed rFIREFOXRELEASE18807ebb0f79: Bug 1986837 - patch 5 - Look at preceding inline frames to initialize the… (authored by jfkthame).
Bug 1986837 - patch 5 - Look at preceding inline frames to initialize the…
Mon, Nov 3, 10:06 AM
TYLin committed rFIREFOXRELEASE61946b8f658d: Bug 1986837 - patch 4 - When a textrun maps multiple content flows, try to use… (authored by jfkthame).
Bug 1986837 - patch 4 - When a textrun maps multiple content flows, try to use…
Mon, Nov 3, 10:06 AM
TYLin committed rFIREFOXRELEASEd0dae437fd9b: Bug 1986837 - patch 2 - Remove the 8-bit buffer exclusion from TextAutospace… (authored by jfkthame).
Bug 1986837 - patch 2 - Remove the 8-bit buffer exclusion from TextAutospace…
Mon, Nov 3, 10:06 AM
TYLin committed rFIREFOXRELEASE8ca3db3a1827: Bug 1986837 - patch 1 - Convert TextAutospace utility methods IsIdeograph and… (authored by jfkthame).
Bug 1986837 - patch 1 - Convert TextAutospace utility methods IsIdeograph and…
Mon, Nov 3, 10:06 AM
TYLin committed rFIREFOXRELEASEcb4d338128a0: Bug 1986837 - patch 3 - Use mozilla::Maybe for the previous class local… (authored by TYLin).
Bug 1986837 - patch 3 - Use mozilla::Maybe for the previous class local…
Mon, Nov 3, 10:06 AM

Sun, Nov 2

TYLin removed a project from D270956: Bug 1997771 - Simplify nsPresContext::GetNearestWidget. r=#layout: testing-exception-unchanged (Doesn't change behavior for users).

question: Can we test this patch?

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Sun, Nov 2, 3:05 AM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin accepted D270956: Bug 1997771 - Simplify nsPresContext::GetNearestWidget. r=#layout.
Sun, Nov 2, 3:03 AM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin accepted D270955: Bug 1997769 - Remove unnecessary weak reference nsCaret::mPresShell. r=#layout,masayuki.

mPresShell is set, but never used. Nice find! (It appears the last usage was removed by bug 1624819 in https://hg-edge.mozilla.org/mozilla-central/diff/324cc7d374d1860a1743fa7f8a33a782e3bd4177/layout/base/nsCaret.cpp)

Sun, Nov 2, 2:50 AM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin accepted D270953: Bug 1997765 - Make CapturedContentInfo not require runtime initialization. r=#layout,sergesanspaille.
Sun, Nov 2, 2:44 AM · testing-exception-unchanged (Doesn't change behavior for users)

Sat, Nov 1

TYLin added inline comments to D270449: Bug 1997026. Update IsAnchorLaidOutStrictlyBeforeElement to spec changes..
Sat, Nov 1, 1:19 AM

Fri, Oct 31

TYLin closed D270798: Bug 1997502 - Simplify two nsBlockFrame methods that remove frames..
Fri, Oct 31, 10:56 AM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin committed rFIREFOXAUTOLANDe7545a3c99fc: Bug 1997502 - Simplify two nsBlockFrame methods that remove frames. r=layout… (authored by TYLin).
Bug 1997502 - Simplify two nsBlockFrame methods that remove frames. r=layout…
Fri, Oct 31, 10:56 AM
TYLin accepted D270812: Bug 1995522 - Cleanup remaining unused mfbt includes r=emilio!.

R+ for layout/.

Fri, Oct 31, 10:33 AM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin created D270798: Bug 1997502 - Simplify two nsBlockFrame methods that remove frames..
Fri, Oct 31, 4:50 AM · testing-exception-unchanged (Doesn't change behavior for users)

Thu, Oct 30

TYLin added inline comments to D270727: Bug 1997418: Simplify `nsBlockFrame`'s abspos cb computation. r=#layout.
Thu, Oct 30, 8:22 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin accepted D270727: Bug 1997418: Simplify `nsBlockFrame`'s abspos cb computation. r=#layout.

Yeah, I've always wanted to look into CalculateContainingBlockSizeForAbsolutes() to see if all the complexity is needed. If the try result looks good, let's land this.

Thu, Oct 30, 8:18 PM · testing-exception-unchanged (Doesn't change behavior for users)
TYLin added a comment to D270377: Bug 1993043 - Enable layout.css.text-decoration-inset.enabled by default.

I think we'll need to replace trim with inset in this patch.

Thu, Oct 30, 4:33 PM · testing-exception-elsewhere (Please comment explaining where the tests are)
TYLin accepted D270566: Bug 1997157 - Rename text-decoration-trim to -inset per CSSWG resolution..

This line also needs to update:
https://searchfox.org/firefox-main/rev/75f89f7dee3f30c371af717da54ba8bbf046e5fd/devtools/server/actors/animation-type-longhand.js#340

Thu, Oct 30, 5:41 AM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)

Wed, Oct 29

TYLin accepted D269575: Bug 1995750. Assert the anchor is in the same containing block as positioned. r?#layout-reviewers.

Thanks for improving this patch!

Wed, Oct 29, 4:48 AM · testing-exception-unchanged (Doesn't change behavior for users)

Tue, Oct 28

TYLin closed D270251: Bug 1996677 Part 4 - Fix a potential writing-mode misuse when initializing abspos child's ReflowInput..
Tue, Oct 28, 8:20 PM · testing-exception-unchanged (Doesn't change behavior for users)
Privacy · Cookies · Legal