This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Wed, Nov 12, 11:52 AM · needs-testing-tag

emilio added inline comments to D272208: Bug 1999623 - Remove more view code. r=#layout,tnikkel.

Wed, Nov 12, 11:52 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio added inline comments to D272208: Bug 1999623 - Remove more view code. r=#layout,tnikkel.

Wed, Nov 12, 11:51 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio added inline comments to D272208: Bug 1999623 - Remove more view code. r=#layout,tnikkel.

Wed, Nov 12, 9:28 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio created D272211: Bug 1999627 - Remove nsViewManager's device context. r=tnikkel,#layout.

Wed, Nov 12, 7:56 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio added inline comments to D272205: Bug 1999620 - Remove some dead view-related code now that popups don't use views. r=#layout,tnikkel.

Wed, Nov 12, 7:54 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio accepted D272210: Bug 1999513 [Wayland] Apply opaque changes only if we have buffer attached to avoid painting of empty window r?emilio.

Wed, Nov 12, 7:52 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D272205: Bug 1999620 - Remove some dead view-related code now that popups don't use views. r=#layout,tnikkel.

Wed, Nov 12, 7:52 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio created D272209: Bug 1999623 - Remove view to widget offset. r=#layout,tnikkel.

Wed, Nov 12, 7:31 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio requested changes to D271829: Bug 1993308 - Fix specified value serialization of <position> in shape() to preserve keyword syntax. r=boris,emilio.

Wed, Nov 12, 7:18 AM

emilio added a comment to D272187: Bug 1998858 - Make `Selection` stop splitting user selected range to exclude non-selectable nodes r=smaug!,emilio!,edgar!,TYLin!.

In D272187#9418779, @masayuki wrote:

In D272187#9418573, @emilio wrote:

Let's add an nsIFrame::IsSelectableOrEditable() const that would do something like return IsSelectable(nullptr) || (mContent && mContent->IsEditable());, then use that during layout?

Sure, but I don't think we need the new API. nsIFrame::IsSelectable() already check the same things. Oh, but it checks whether the frame is an editing host rather than editable. I think it should return StyleUserSelect::Text when the content is editable.
https://searchfox.org/firefox-main/rev/6abddcb0a5076c3b888686ede6f4cf7d082460d3/layout/generic/nsIFrame.cpp#4776-4797

Wed, Nov 12, 6:46 AM

emilio created D272208: Bug 1999623 - Remove more view code. r=#layout,tnikkel.

Wed, Nov 12, 6:39 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio created D272207: Bug 1999622 - Remove nsIFrame::GetClosestView. r=#layout,tnikkel.

Wed, Nov 12, 6:39 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio created D272206: Bug 1999621 - Remove nsIFrame::GetOffsetFromView. r=#layout,tnikkel.

Wed, Nov 12, 6:39 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio created D272205: Bug 1999620 - Remove some dead view-related code now that popups don't use views. r=#layout,tnikkel.

Wed, Nov 12, 6:39 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio created D272204: Bug 1999619 - Remove nsIBaseWindow.repaint(). r=#layout,tnikkel,smaug,#dom-core.

Wed, Nov 12, 6:39 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio added a comment to D272202: Bug 1946263 - Clear mouse capture only if under the document that's going away. r=#layout,tnikkel.

In D272202#9418697, @tnikkel wrote:

Is the problem actually that a subdocument is getting destroyed and we are clearing mouse capture everywhere even though the mouse capture is not in the subdocument (its in a parent doc)?

Wed, Nov 12, 6:30 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

emilio created D272202: Bug 1946263 - Clear mouse capture only if under the document that's going away. r=#layout,tnikkel.

Wed, Nov 12, 6:09 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

emilio closed D272121: Bug 1998071 - Deal with transform-origin consistently for textPath. r=longsonr,#firefox-svg-reviewers.

Wed, Nov 12, 5:22 AM · testing-approved

emilio accepted D270840: Bug 1997564 - Make `math-depth` animate like an integer r?emilio,fredw.

Wed, Nov 12, 5:22 AM · testing-approved

emilio edited projects for D271842: Bug 1768116 - updated libwebrtc moz.build files. r=mjf, added: testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.

Wed, Nov 12, 5:16 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio edited projects for D271779: Bug 1768116 - Compile as C++20. r=glandium!, added: testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.

Wed, Nov 12, 5:14 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D271779: Bug 1768116 - Compile as C++20. r=glandium!.

Wed, Nov 12, 5:00 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio requested changes to D272187: Bug 1998858 - Make `Selection` stop splitting user selected range to exclude non-selectable nodes r=smaug!,emilio!,edgar!,TYLin!.

Wed, Nov 12, 4:56 AM

emilio added a comment to D272187: Bug 1998858 - Make `Selection` stop splitting user selected range to exclude non-selectable nodes r=smaug!,emilio!,edgar!,TYLin!.

Let's add an nsIFrame::IsSelectableOrEditable() const that would do something like return IsSelectable(nullptr) || (mContent && mContent->IsEditable());, then use that during layout?

Wed, Nov 12, 4:56 AM

emilio added inline comments to D271779: Bug 1768116 - Compile as C++20. r=glandium!.

Wed, Nov 12, 3:16 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio requested review of D271779: Bug 1768116 - Compile as C++20. r=glandium!.

Wed, Nov 12, 3:15 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio closed D232057: Bug 1994942 - Don't use views for subdocs. r=tnikkel,#layout.

This landed...

Wed, Nov 12, 1:49 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D271205: Bug 1998125 - Remove a lot of now unused view code. r=#layout.

resize viewport view

Wed, Nov 12, 1:48 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio edited projects for D271931: Bug 1999057 - Add msvcp140_atomic_wait.dll to fix debug SM shell builds with c++20. r?glandium!, added: testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.

Wed, Nov 12, 1:39 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio edited projects for D271601: Bug 1992321 - Don't prevent mozilla-config.h inclusion in all rust-built C++. r=glandium!, added: testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.

Wed, Nov 12, 1:38 AM · testing-exception-unchanged (Doesn't change behavior for users)

Tue, Nov 11

emilio updated the diff for D271205: Bug 1998125 - Remove a lot of now unused view code. r=#layout.

rebase

Tue, Nov 11, 4:42 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio edited projects for D271314: Bug 1998285 - Make computed borders not affect the computed value. r=#layout,#style, added: testing-approved; removed needs-testing-tag.

I'll take it.

Tue, Nov 11, 4:24 PM · testing-approved

emilio edited projects for D272142: Bug 1999326 - Fix ancestor-search loop in GetFrameLineNum() to properly handle first-line frames if present. r=#layout, added: testing-approved; removed testing-exception-unchanged (Doesn't change behavior for users).

Tue, Nov 11, 1:24 PM · testing-approved

emilio accepted D272142: Bug 1999326 - Fix ancestor-search loop in GetFrameLineNum() to properly handle first-line frames if present. r=#layout.

Tue, Nov 11, 1:24 PM · testing-approved

emilio updated the diff for D272109: Bug 1994942 - Use FrameToWidgetOffset more and remove TranslateViewToWidget(). r=tnikkel.

clang-format

Tue, Nov 11, 1:23 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D272109: Bug 1994942 - Use FrameToWidgetOffset more and remove TranslateViewToWidget(). r=tnikkel.

rebase

Tue, Nov 11, 12:53 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D271205: Bug 1998125 - Remove a lot of now unused view code. r=#layout.

Tue, Nov 11, 9:01 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio added a comment to D271205: Bug 1998125 - Remove a lot of now unused view code. r=#layout.

Tue, Nov 11, 8:47 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D271205: Bug 1998125 - Remove a lot of now unused view code. r=#layout.

rebase

Tue, Nov 11, 8:40 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio accepted D272119: Bug 1999432 - Focibly use WhereToScroll::Nearest for zoom-to-focused-input for position:fixed elements. r?botond,dlrobertson.

Tue, Nov 11, 8:29 AM · testing-approved

emilio added inline comments to D272119: Bug 1999432 - Focibly use WhereToScroll::Nearest for zoom-to-focused-input for position:fixed elements. r?botond,dlrobertson.

Tue, Nov 11, 8:26 AM · testing-approved

emilio accepted D271449: Bug 1998052: Update wgpu to upstream 690d4ee0 (2025-11-06) r=#webgpu-reviewers!.

Tue, Nov 11, 8:25 AM · testing-approved

emilio accepted D271802: Bug 1988030. Adjust DisplayPortUtils::OneStepInAsyncScrollableAncestorChain to be CSS anchor pos aware. r?#layout-reviewers,botond,hiro.

Tue, Nov 11, 8:24 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio accepted D271802: Bug 1988030. Adjust DisplayPortUtils::OneStepInAsyncScrollableAncestorChain to be CSS anchor pos aware. r?#layout-reviewers,botond,hiro.

Tue, Nov 11, 8:24 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio added a comment to D232057: Bug 1994942 - Don't use views for subdocs. r=tnikkel,#layout.

In D232057#9414809, @tnikkel wrote:

Thanks for bearing with all my comments!!

Tue, Nov 11, 7:30 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio created D272121: Bug 1998071 - Deal with transform-origin consistently for textPath. r=longsonr,#firefox-svg-reviewers.

Tue, Nov 11, 7:08 AM · testing-approved

emilio updated the diff for D232057: Bug 1994942 - Don't use views for subdocs. r=tnikkel,#layout.

Tue, Nov 11, 6:13 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio added inline comments to D232057: Bug 1994942 - Don't use views for subdocs. r=tnikkel,#layout.

Tue, Nov 11, 5:49 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D232057: Bug 1994942 - Don't use views for subdocs. r=tnikkel,#layout.

Tue, Nov 11, 5:47 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D232057: Bug 1994942 - Don't use views for subdocs. r=tnikkel,#layout.

Tue, Nov 11, 5:42 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D272109: Bug 1994942 - Use FrameToWidgetOffset more and remove TranslateViewToWidget(). r=tnikkel.

Tue, Nov 11, 3:35 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio updated the diff for D232057: Bug 1994942 - Don't use views for subdocs. r=tnikkel,#layout.

Tue, Nov 11, 3:35 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio requested changes to D271528: Bug 1998572 - Ensure backdrop-filter roots are established for clip paths.

D272111 is what I was thinking of, is there any reason that wouldn't work? If so please re-request review?

Tue, Nov 11, 3:33 AM

emilio created D272111: Bug 1998572 - Ensure masks/clip-path isolate for backdrop-filter if needed. r=gw!.

Tue, Nov 11, 3:32 AM · testing-approved

emilio accepted D271805: Bug 1988030. Create nsLayoutUtils::GetActivatedScrollableAncestorFrame that walks only scroll frames that are currently async scrollable. r?botond,hiro.

Tue, Nov 11, 3:16 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio abandoned D272108: Bug 1994942 - Use FrameToWidgetOffset more and remove TranslateViewToWidget(). r=tnikkel.

Phab was struggling today.

Tue, Nov 11, 3:09 AM

emilio created D272109: Bug 1994942 - Use FrameToWidgetOffset more and remove TranslateViewToWidget(). r=tnikkel.

Tue, Nov 11, 3:03 AM · testing-exception-unchanged (Doesn't change behavior for users)

emilio created D272108: Bug 1994942 - Use FrameToWidgetOffset more and remove TranslateViewToWidget(). r=tnikkel.

Tue, Nov 11, 3:02 AM

emilio updated the diff for D232057: Bug 1994942 - Don't use views for subdocs. r=tnikkel,#layout.

Tue, Nov 11, 3:02 AM · testing-exception-unchanged (Doesn't change behavior for users)

Mon, Nov 10

emilio removed a reviewer for D271784: Bug 1897620 - Remove image.avif.enabled pref: layout-reviewers.

Mon, Nov 10, 11:52 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio accepted D271987: Bug 1998949 [Wayland] Don't fire bounds recalculation from configure event on Wayland as we relly on mContainer GdkWindow size r?emilio.

If this works, great. It used to cause some intermittents ime.

Mon, Nov 10, 11:49 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio accepted D271986: Bug 1998949 [Wayland] Propagate correct window coordinates constraint to layout r?emilio.

Mon, Nov 10, 11:48 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio accepted D271985: Bug 1998949 [Wayland] Add more logging to popup placement code r?emilio.

Mon, Nov 10, 11:48 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio added a comment to D271897: Bug 1999117 - Coerce singular matrix from GetCTM to identity. r=longsonr,#firefox-svg-reviewers.

@longsonr I had to tweak this to apply only to the GetCTM because otherwise we would start rendering things like layout/reftests/svg/viewBox-invalid-02.svg.

Mon, Nov 10, 11:36 PM · testing-approved

emilio updated the diff for D271926: Bug 1998440 - Deal with having the same frame tree position in different frames. r=#layout.

Mon, Nov 10, 11:32 PM · testing-approved

emilio accepted D272045: Bug 1999164 - If unicode-range is simply 0..10FFFF, don't bother to create a gfxCharacterMap for it as nothing will be masked. r=#layout.

Mon, Nov 10, 10:04 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio accepted D271664: Bug 1999325 - Replace custom --font-size-xsmall in _theme.scss with the design token. <Hanna Jones [:hjones]>.

Mon, Nov 10, 12:14 PM · testing-exception-unchanged (Doesn't change behavior for users)

emilio requested changes to D271829: Bug 1993308 - Fix specified value serialization of <position> in shape() to preserve keyword syntax. r=boris,emilio.

I think this can be simpler, see the question above.

Mon, Nov 10, 12:12 PM

emilio accepted D271800: Bug 1988030. Adjust nsLayoutUtils::GetAsyncScrollableAncestorFrame to be CSS anchor pos aware. r?#layout-reviewers,botond,hiro.

Not sure what the test situation is for this.