User Details
- User Since
- Aug 22 2018, 2:29 PM (376 w, 5 d)
- Availability
- Available
- Review Queue
- 1
Yesterday
Fri, Nov 7
Tue, Nov 4
Looks great!
Mon, Nov 3
Looks great! r+ with one suggestion
Tue, Oct 28
r+ for GLContext.cpp and GeckoSurfaceTexture.java
r+ for gfx stuff
Shall we add a comment to the CreateContentBridges declaration documenting that it is the caller's responsibility to ensure the GPU is ready?
Thu, Oct 23
Wed, Oct 22
only affects xpcshell and geckoview-junit tests
@janerik From the discussion in bug 1995596, would you rather I update the comments with a specific reason for the disabling the tests rather than a link to a bug? (to me the bug link implies they're temporarily being skipped due to them failing as opposed to not wanting to run them in the first place)
Tue, Oct 21
Mon, Oct 20
I was hitting the xpcshell and junit failures doing this. Have you done a try run?
Sat, Oct 18
Fri, Oct 17
device specific workaround
Should this be titled "add to peers" instead of webgpu-reviewers? I'm already in the phab group
Thu, Oct 16
We should really remove AndroidHardwareBufferApi altogether and just call the functions directly. But understand if that's more than you want to bite off with this.. so r+ for HardwareBuffer stuff
Wed, Oct 15
Device specific workaround
Tue, Oct 14
Mon, Oct 13
: config change
Oct 9 2025
GPUProcessManager should only exist in the parent process. We assert that here. Why is this getting called in the GPU process at all?
Oct 7 2025
I think it's more complicated than this, unfortunately.
Oct 6 2025
Sep 18 2025
This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!
Sep 15 2025
Sep 8 2025
This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!
Sep 3 2025
whoops, think this one was my fault!
