I've started a try run on firefox-main to see current intermittent status

r+ for toolkit/components/antitracking/

Thanks for the quick fix!

I'll land after soft-code freeze ended.

Thanks! Change looks good now.

Thanks! That looks clean :)

I tried it on the url that is on the bug and it seems like we are missing a few query paramters

Seems like you did end up creating a new revision (D271523). That is ok, but please abandon this revision, I've gone ahead and reviewed + landed the new revision.

testing-exception-other: Copy Clean Link already has automated test coverage. We don't test individual strip list entries.

Thanks! The change itself looks good. Please update the bug number, but would be good to go then. You can use "Edit revision" in this patch or update the commit message and resubmit the patch with moz-phab. Make sure it keeps the "https://phabricator.services.mozilla.com/D271511" at the bottom of the commit message so that moz-phab updates the correct patch.

One first unexpected thing that occured to me when trying to test on breakage bugs: (the ryanair one): When reconstructing the site from the partitionKey, we discard the subdomain (www.). However our rules are based on url-pattern, that usually specify the exact origin. We need to take care to then unblock both origins (e.g. www.ryanair.com and ryanair.com).

Would be good to investigate. But we can do that separately. Please open a bug to keep track on this.

fix lints

Make patch ready for review (tests still missing though)

rebase

undo version change so stack can land without conflict

Login works with this shim. Thanks for investigating and writing a patch. Looks like we need a few more shims for the brekages in https://bugzilla.mozilla.org/show_bug.cgi?id=1959711, but good the cause & how to fix.

Try run in https://treeherder.mozilla.org/jobs?revision=0cd4bd7d114e6448d95c8ac0850bd432a25314a2&repo=try.

Thanks. Looks good to me. (testing/web-platform/tests/gpc/*). Only minor nits. (and the first one only because I had another one).

put fixup url into search field & default to https

address review

Thanks for taking a look and fixing :)

When runing the tests I did get a test failures (but seems to be intermittent):

I don't think the approach I took was the best one. It's probably possible to do less invasive. Abandoning, because I no longer work on it.

remove unrelated changes 🤦

fix spelling (didn't run git add last time)

fix spelling

Could potentially also be data-classification-unnecessary

Thanks! Looks good :)