User Details
User Details
- User Since
- Jan 3 2020, 8:38 AM (305 w, 3 d)
- Availability
- Available
- Review Queue
- 0
Yesterday
Yesterday
mcarare committed rFIREFOXBETAcdb28fa88c2b: Bug 1998699 - Use onResume/onPause for listener registration/unregistration in… (authored by mcarare).
Bug 1998699 - Use onResume/onPause for listener registration/unregistration in…
mcarare committed rFIREFOXBETAef5b800cf0a9: Bug 1996633 - Remove mockkStatic usage in HomeToolbarViewTest. r=android… (authored by mcarare).
Bug 1996633 - Remove mockkStatic usage in HomeToolbarViewTest. r=android…
mcarare committed rFIREFOXBETA04f729c8bcd0: Bug 1996624 - Remove mockkStatic usage in DefaultToolbarIntegrationTest. (authored by mcarare).
Bug 1996624 - Remove mockkStatic usage in DefaultToolbarIntegrationTest.
mcarare committed rFIREFOXBETAca4be57478b7: Bug 1998448 - Override `mozac_ui_icons_fill` color for Focus. r=android… (authored by mcarare).
Bug 1998448 - Override `mozac_ui_icons_fill` color for Focus. r=android…
mcarare committed rFIREFOXBETAce3d2bb176ef: Bug 1996623 - Simplify HomeSettingsFragment and improve testability r=android… (authored by mcarare).
Bug 1996623 - Simplify HomeSettingsFragment and improve testability r=android…
mcarare committed rFIREFOXBETAe5c691fd077a: Bug 1998351 - Remove Robolectric from TextHighlightingTest r=android-reviewers… (authored by mcarare).
Bug 1998351 - Remove Robolectric from TextHighlightingTest r=android-reviewers…
mcarare committed rFIREFOXBETAf388efa30e9c: Bug 1996631 - Improve testability of DefaultLocaleSettingsController r=android… (authored by mcarare).
Bug 1996631 - Improve testability of DefaultLocaleSettingsController r=android…
mcarare committed rFIREFOXBETAa44e6ff6ffc0: Bug 1997939 - Extract DownloadCancelDialogFragment creation in… (authored by mcarare).
Bug 1997939 - Extract DownloadCancelDialogFragment creation in…
mcarare committed rFIREFOXBETA02679476ca2a: Bug 1997888 - Use real LocaleManager in tests. r=android-reviewers,giorga (authored by mcarare).
Bug 1997888 - Use real LocaleManager in tests. r=android-reviewers,giorga
mcarare committed rFIREFOXBETA7a0649902e98: Bug 1996627 - Refactor tabs cleanup logic and testing r=android-reviewers,giorga (authored by mcarare).
Bug 1996627 - Refactor tabs cleanup logic and testing r=android-reviewers,giorga
mcarare committed rFIREFOXBETAf320908698fa: Bug 1996630 - Inject Settings into TrackingProtectionPanelView. r=android… (authored by mcarare).
Bug 1996630 - Inject Settings into TrackingProtectionPanelView. r=android…
mcarare committed rFIREFOXBETA8b8cd08d51ed: Bug 1996568 - Abstract display unit conversion for better testability. (authored by mcarare).
Bug 1996568 - Abstract display unit conversion for better testability.
mcarare committed rFIREFOXBETA64b002161e1d: Bug 1996546 - Remove mockkStatic usage from AboutPageAdapterTest. r=android… (authored by mcarare).
Bug 1996546 - Remove mockkStatic usage from AboutPageAdapterTest. r=android…
mcarare committed rFIREFOXBETA089a74ef4ada: Bug 1975496 - Remove mockkStatic usage from BrowserToolbarMiddlewareTest. (authored by mcarare).
Bug 1975496 - Remove mockkStatic usage from BrowserToolbarMiddlewareTest.
mcarare committed rFIREFOXBETA5b672c8037ef: Bug 1994480 - Remove unused drawable resources. r=android-reviewers,avirvara (authored by mcarare).
Bug 1994480 - Remove unused drawable resources. r=android-reviewers,avirvara
mcarare committed rFIREFOXBETAcde214eee7e3: Bug 1994480 - Migrate Focus icons to mozac-icons. r=android-reviewers,avirvara (authored by mcarare).
Bug 1994480 - Migrate Focus icons to mozac-icons. r=android-reviewers,avirvara
mcarare committed rFIREFOXBETA2f4d2e2a7ba4: Bug 1993740 - Remove MainCoroutineRule from RunWhenReadyQueueTest. r=android… (authored by mcarare).
Bug 1993740 - Remove MainCoroutineRule from RunWhenReadyQueueTest. r=android…
mcarare committed rFIREFOXBETAd1c0d07f4951: Bug 1993721 - Remove MainCoroutineRule from ViewTest. r=android-reviewers,giorga (authored by mcarare).
Bug 1993721 - Remove MainCoroutineRule from ViewTest. r=android-reviewers,giorga
mcarare committed rFIREFOXBETA852cb6e02c13: Bug 1993482 - Migrate settings screen to Jetpack Compose. r=android-reviewers… (authored by mcarare).
Bug 1993482 - Migrate settings screen to Jetpack Compose. r=android-reviewers…
mcarare committed rFIREFOXAUTOLAND5268af90d488: Bug 1998659 - Migrate AboutFragment to be fully composable r=android-reviewers… (authored by mcarare).
Bug 1998659 - Migrate AboutFragment to be fully composable r=android-reviewers…
mcarare committed rFIREFOXAUTOLANDa07e6bed44d2: Bug 1966853 - Centralize navigation logic in MainActivityNavigation r=android… (authored by mcarare).
Bug 1966853 - Centralize navigation logic in MainActivityNavigation r=android…
Fri, Nov 7
Fri, Nov 7
mcarare accepted D271678: Bug 1998801 - Remove redundant null-safety after prior null checks. r=#android-reviewers.
good review suggestions from the plugin, but not necessarily in the scope of this.
Thu, Nov 6
Thu, Nov 6
mcarare committed rFIREFOXAUTOLANDcdb28fa88c2b: Bug 1998699 - Use onResume/onPause for listener registration/unregistration in… (authored by mcarare).
Bug 1998699 - Use onResume/onPause for listener registration/unregistration in…
mcarare committed rFIREFOXAUTOLANDef5b800cf0a9: Bug 1996633 - Remove mockkStatic usage in HomeToolbarViewTest. r=android… (authored by mcarare).
Bug 1996633 - Remove mockkStatic usage in HomeToolbarViewTest. r=android…
mcarare added a comment to D271573: Bug 1996633 - Remove mockkStatic usage in HomeToolbarViewTest..
mcarare committed rFIREFOXAUTOLAND04f729c8bcd0: Bug 1996624 - Remove mockkStatic usage in DefaultToolbarIntegrationTest. (authored by mcarare).
Bug 1996624 - Remove mockkStatic usage in DefaultToolbarIntegrationTest.
mcarare updated the diff for D271543: Bug 1996624 - Remove mockkStatic usage in DefaultToolbarIntegrationTest..
mcarare accepted D271464: Bug 1998506 - Update AndroidX Core Splashscreen to version 1.2.0. r=#android-reviewers.
We should also re-test 1919488 after this lands to see if this update changes the issue.
Wed, Nov 5
Wed, Nov 5
mcarare committed rFIREFOXAUTOLANDca4be57478b7: Bug 1998448 - Override `mozac_ui_icons_fill` color for Focus. r=android… (authored by mcarare).
Bug 1998448 - Override `mozac_ui_icons_fill` color for Focus. r=android…
mcarare committed rFIREFOXAUTOLANDce3d2bb176ef: Bug 1996623 - Simplify HomeSettingsFragment and improve testability r=android… (authored by mcarare).
Bug 1996623 - Simplify HomeSettingsFragment and improve testability r=android…
mcarare added a comment to D271382: Bug 1996623 - Simplify HomeSettingsFragment and improve testability.
mcarare committed rFIREFOXAUTOLANDe5c691fd077a: Bug 1998351 - Remove Robolectric from TextHighlightingTest r=android-reviewers… (authored by mcarare).
Bug 1998351 - Remove Robolectric from TextHighlightingTest r=android-reviewers…
mcarare committed rFIREFOXAUTOLANDf388efa30e9c: Bug 1996631 - Improve testability of DefaultLocaleSettingsController r=android… (authored by mcarare).
Bug 1996631 - Improve testability of DefaultLocaleSettingsController r=android…
mcarare added a comment to D269610: Bug 1966853 - Centralize navigation logic in MainActivityNavigation.
mcarare requested review of D269610: Bug 1966853 - Centralize navigation logic in MainActivityNavigation.
mcarare added a comment to D271363: Bug 1998351 - Remove Robolectric from TextHighlightingTest.
mcarare added a comment to D271359: Bug 1996631 - Improve testability of DefaultLocaleSettingsController.
Tue, Nov 4
Tue, Nov 4
mcarare committed rFIREFOXAUTOLANDa44e6ff6ffc0: Bug 1997939 - Extract DownloadCancelDialogFragment creation in… (authored by mcarare).
Bug 1997939 - Extract DownloadCancelDialogFragment creation in…
Mon, Nov 3
Mon, Nov 3
mcarare committed rFIREFOXAUTOLAND02679476ca2a: Bug 1997888 - Use real LocaleManager in tests. r=android-reviewers,giorga (authored by mcarare).
Bug 1997888 - Use real LocaleManager in tests. r=android-reviewers,giorga
mcarare added a comment to D271059: Bug 1997888 - Use real LocaleManager in tests..
mcarare committed rFIREFOXRELEASEc04e52aa0c31: Bug 1993566 - Remove MainCoroutineRule from DefaultTopSitesStorageTest. (authored by mcarare).
Bug 1993566 - Remove MainCoroutineRule from DefaultTopSitesStorageTest.
mcarare committed rFIREFOXRELEASEcca90458683e: Bug 1993557 - Remove MainCoroutineRule from BrowserToolbarStoreTest. r=android… (authored by mcarare).
Bug 1993557 - Remove MainCoroutineRule from BrowserToolbarStoreTest. r=android…
mcarare committed rFIREFOXRELEASE8c4eb2bb4c61: Bug 1993554 - Remove MainCoroutineRule from WebNotificationFeatureTest. (authored by mcarare).
Bug 1993554 - Remove MainCoroutineRule from WebNotificationFeatureTest.
mcarare committed rFIREFOXRELEASE16d56a67ab07: Bug 1993564 - Remove MainCoroutineRule from GeckoEngineSessionTest. r=android… (authored by mcarare).
Bug 1993564 - Remove MainCoroutineRule from GeckoEngineSessionTest. r=android…
mcarare committed rFIREFOXRELEASE001ea90900b8: Bug 1993528 - Remove MainCoroutineRule from NimbusMessagingStorageTest. (authored by mcarare).
Bug 1993528 - Remove MainCoroutineRule from NimbusMessagingStorageTest.
mcarare committed rFIREFOXRELEASE7ea1e7c13a07: Bug 1993327 - Update checkbox and radio button styling. r=android-reviewers… (authored by mcarare).
Bug 1993327 - Update checkbox and radio button styling. r=android-reviewers…
mcarare committed rFIREFOXRELEASEcde75246bb96: Bug 1993170 - Improve TrackingProtectionBlockingFragment testability. r=android… (authored by mcarare).
Bug 1993170 - Improve TrackingProtectionBlockingFragment testability. r=android…
mcarare committed rFIREFOXRELEASEab583895c529: Bug 1993010 - Migrate GleanMetricsServiceTest from runBlocking to runTest. (authored by mcarare).
Bug 1993010 - Migrate GleanMetricsServiceTest from runBlocking to runTest.
mcarare committed rFIREFOXRELEASE738243227c4f: Bug 1992015 - Remove MainCoroutineRule from crash reporting test code. (authored by mcarare).
Bug 1992015 - Remove MainCoroutineRule from crash reporting test code.
mcarare committed rFIREFOXRELEASE89c4b1d36f8f: Bug 1889427 - Migrate TelemetryMiddlewareTest to runTest. r=android-reviewers… (authored by mcarare).
Bug 1889427 - Migrate TelemetryMiddlewareTest to runTest. r=android-reviewers…
mcarare committed rFIREFOXRELEASE90439dd151ee: Bug 1992735 - Add KDoc for language related code. r=android-reviewers,avirvara (authored by mcarare).
Bug 1992735 - Add KDoc for language related code. r=android-reviewers,avirvara
mcarare committed rFIREFOXRELEASEd4a1cd08e72f: Bug 1992818 - Simplify VisibilityLifeCycleCallback by using… (authored by mcarare).
Bug 1992818 - Simplify VisibilityLifeCycleCallback by using…
mcarare committed rFIREFOXRELEASE3166cb355e99: Bug 1992735 - Refactor Language selection screen to improve performance and… (authored by mcarare).
Bug 1992735 - Refactor Language selection screen to improve performance and…
mcarare committed rFIREFOXRELEASE30ff531034cb: Bug 1992807 - Update detekt baseline. r=android-reviewers,avirvara (authored by mcarare).
Bug 1992807 - Update detekt baseline. r=android-reviewers,avirvara
mcarare committed rFIREFOXRELEASE7d653e24b3b1: Bug 1992724 - Move TopAppBar into Scaffold topBar parameter r=android-reviewers… (authored by mcarare).
Bug 1992724 - Move TopAppBar into Scaffold topBar parameter r=android-reviewers…
mcarare committed rFIREFOXRELEASEaf81db4260bd: Bug 1992395 - Update SwitchCompat and SwitchMaterial thumb and track colors. (authored by mcarare).
Bug 1992395 - Update SwitchCompat and SwitchMaterial thumb and track colors.
mcarare committed rFIREFOXRELEASE3e9c784a7953: Bug 1992046 - Replace MainScope with a custom CoroutineScope in… (authored by mcarare).
Bug 1992046 - Replace MainScope with a custom CoroutineScope in…
mcarare committed rFIREFOXRELEASE8db860e6f949: Bug 1991559 - Migrate browser state tests to use BrowserStateReducer directly. (authored by mcarare).
Bug 1991559 - Migrate browser state tests to use BrowserStateReducer directly.
mcarare committed rFIREFOXRELEASEf9560c499263: Bug 1991559 - Refactor AppState related tests to use the AppStoreReducer… (authored by mcarare).
Bug 1991559 - Refactor AppState related tests to use the AppStoreReducer…
mcarare committed rFIREFOXRELEASE17320010deeb: Bug 1991559 - Migrate SitePermissionOptionsStore to a plain object reducer… (authored by mcarare).
Bug 1991559 - Migrate SitePermissionOptionsStore to a plain object reducer…
mcarare committed rFIREFOXRELEASEc4473522f977: Bug 1991158 - Migrate from SwitchPreferenceCompat to Material3 SwitchPreference. (authored by mcarare).
Bug 1991158 - Migrate from SwitchPreferenceCompat to Material3 SwitchPreference.
mcarare committed rFIREFOXRELEASEee63c6e0f362: Bug 1992083 - Apply custom dialog styling to MaterialAlertDialog r=android… (authored by mcarare).
Bug 1992083 - Apply custom dialog styling to MaterialAlertDialog r=android…
mcarare committed rFIREFOXRELEASEfc017a4ccf88: Bug 1991994 - Document Settings.kt and remove unused preference keys. r=android… (authored by mcarare).
Bug 1991994 - Document Settings.kt and remove unused preference keys. r=android…
mcarare committed rFIREFOXRELEASE24eb3096279d: Bug 1991884 - Update "Add to Home Screen" dialog button style. r=android… (authored by mcarare).
Bug 1991884 - Update "Add to Home Screen" dialog button style. r=android…
mcarare committed rFIREFOXRELEASE46eb82d1165b: Bug 1991912 - Update popup menu background. r=android-reviewers,avirvara (authored by mcarare).
Bug 1991912 - Update popup menu background. r=android-reviewers,avirvara
mcarare committed rFIREFOXRELEASE078b8c71d27f: Bug 1991906 - Use MaterialTheme typography for language display name r=android… (authored by mcarare).
Bug 1991906 - Use MaterialTheme typography for language display name r=android…
mcarare committed rFIREFOXRELEASE9cabd6e68760: Bug 1991878 - Update downloads dialog styling. r=android-reviewers,giorga (authored by mcarare).
Bug 1991878 - Update downloads dialog styling. r=android-reviewers,giorga
mcarare committed rFIREFOXRELEASE0a08e3bb6189: Bug 1991659 - Update Site Permissions dialog styling r=android-reviewers… (authored by mcarare).
Bug 1991659 - Update Site Permissions dialog styling r=android-reviewers…
mcarare committed rFIREFOXRELEASEdcd39b58cd96: Bug 1990183 - Prevent using recycled bitmaps for PWA icons. r=android-reviewers… (authored by mcarare).
Bug 1990183 - Prevent using recycled bitmaps for PWA icons. r=android-reviewers…
