ng (Nico Grunbaum)
User

Projects

webrtc-reviewers
Group

Calendar

User Details

User Since: Dec 13 2017, 10:49 PM (412 w, 5 d)
Availability: Available
Review Queue: 0

Recent Activity
View All

Yesterday

ng committed rFIREFOXBETAd420ac2ce250: Bug 1963327 - Update libepoxy to bb7ddbc7bd1ee879ec50aa281dcb10cfaefb784c r=ng (authored by updatebot).

Bug 1963327 - Update libepoxy to bb7ddbc7bd1ee879ec50aa281dcb10cfaefb784c r=ng

Mon, Nov 10, 2:01 PM

ng committed rFIREFOXBETAe09440858244: Bug 1993149 - enable JsepTrack.SimulcastRejected on all platforms r=dbaker (authored by ng).

Bug 1993149 - enable JsepTrack.SimulcastRejected on all platforms r=dbaker

Mon, Nov 10, 2:01 PM

Sat, Nov 8

ng updated the diff for D271656: Bug 1571470 - add SVC related failure metrics;r=bwc.

Sat, Nov 8, 7:04 PM · needs-testing-tag, Restricted Project

ng updated the diff for D271693: Bug 1571470 - add SVC setParameters failures;r=dbaker,bwc.

Sat, Nov 8, 7:04 PM · needs-testing-tag, Restricted Project

ng created D271884: Bug 1571470 - wpt to verify H264 produces correct SVC layers;r=jib,pehrsons.

Sat, Nov 8, 9:04 AM

ng created D271883: Bug 1571470 - wpt to verify VP8 produces correct SVC layers;r=jib,pehrsons.

Sat, Nov 8, 9:04 AM

ng created D271882: Bug 1571470 - wpt to verify AV1 produces correct SVC layers;r=jib,pehrsons.

Sat, Nov 8, 9:03 AM

ng created D271881: Bug 1571470 - wpt to verify VP9 produces correct SVC layers;r=jib,pehrsons.

Sat, Nov 8, 9:03 AM

ng requested review of D270794: Bug 1571470 - add wpt helper to check that SVC is used when requested;r=jib,pehrsons.

Sat, Nov 8, 9:03 AM

ng added inline comments to D270794: Bug 1571470 - add wpt helper to check that SVC is used when requested;r=jib,pehrsons.

Sat, Nov 8, 3:36 AM

ng accepted D271845: Bug 1997515 - update generated libwebrtc moz.build files. r?ng!.

Sat, Nov 8, 3:09 AM · testing-exception-unchanged (Doesn't change behavior for users)

ng accepted D271844: Bug 1997515 - remove hardening settings from third_party/chromium/build r?ng!.

Sat, Nov 8, 3:08 AM · testing-exception-unchanged (Doesn't change behavior for users)

ng edited projects for D271848: Bug 1997515 - update generated abseil-cpp moz.build files. r?ng!, added: testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag.

Sat, Nov 8, 3:08 AM · testing-exception-unchanged (Doesn't change behavior for users)

ng accepted D271848: Bug 1997515 - update generated abseil-cpp moz.build files. r?ng!.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Sat, Nov 8, 3:07 AM · testing-exception-unchanged (Doesn't change behavior for users)

ng updated the diff for D271694: Bug 1571470 - add video conduit test for setting scalabilty mode;r=bwc.

Sat, Nov 8, 2:49 AM · testing-approved

ng requested review of D271693: Bug 1571470 - add SVC setParameters failures;r=dbaker,bwc.

Sat, Nov 8, 2:49 AM · needs-testing-tag, Restricted Project

ng updated the diff for D271656: Bug 1571470 - add SVC related failure metrics;r=bwc.

Sat, Nov 8, 2:48 AM · needs-testing-tag, Restricted Project

ng requested review of D271655: Bug 1571470 - apply SVC configuration;r=dbaker,pehrsons.

Sat, Nov 8, 2:48 AM

ng updated the diff for D271654: Bug 1571470 - implement SVC getParameters;r=dbaker.

Sat, Nov 8, 2:47 AM

ng updated the diff for D271653: Bug 1571470 - implement SVC setParameters;r=dbaker.

Sat, Nov 8, 2:46 AM

ng updated the diff for D271652: Bug 1571470 - implement SVC addTransceiver;r=dbaker.

Sat, Nov 8, 2:46 AM

ng updated the diff for D271651: Bug 1571470 - add dd header extension for senders;r?bwc.

Sat, Nov 8, 2:45 AM · testing-approved

ng updated the diff for D271649: Bug 1571470 - add common ScalabilityInfo;r?dbaker.

Sat, Nov 8, 2:43 AM

Fri, Nov 7

ng updated the diff for D271694: Bug 1571470 - add video conduit test for setting scalabilty mode;r=bwc.

Fri, Nov 7, 7:13 AM · testing-approved

ng updated the diff for D271693: Bug 1571470 - add SVC setParameters failures;r=dbaker,bwc.

Fri, Nov 7, 7:12 AM · needs-testing-tag, Restricted Project

ng updated the diff for D271654: Bug 1571470 - implement SVC getParameters;r=dbaker.

Fri, Nov 7, 7:11 AM

ng updated the diff for D271653: Bug 1571470 - implement SVC setParameters;r=dbaker.

Fri, Nov 7, 7:10 AM

ng updated the diff for D271652: Bug 1571470 - implement SVC addTransceiver;r=dbaker.

Fri, Nov 7, 7:10 AM

ng updated the diff for D271651: Bug 1571470 - add dd header extension for senders;r?bwc.

Fri, Nov 7, 7:09 AM · testing-approved

ng abandoned D271662: Bug 1571470 - add common ScalabilityInfo;r?dbaker.

Fri, Nov 7, 7:09 AM

ng updated the diff for D230210: Bug 1571470 - add SVC mode fallback;r?dbaker.

Fri, Nov 7, 7:09 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255691: Bug 1571470 - add scalabilityMode stat handling to GetStats mochitest;r?dbaker.

Fri, Nov 7, 7:08 AM · testing-approved

ng reclaimed D271649: Bug 1571470 - add common ScalabilityInfo;r?dbaker.

Fri, Nov 7, 7:08 AM

ng updated the diff for D255690: Bug 1571470 - set scalabilityMode stat WPT expectation to PASS;r?dbaker.

Fri, Nov 7, 7:07 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255689: Bug 1571470 - fill in scalabilityMode stat in RTPSender;r?dbaker.

Fri, Nov 7, 7:07 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255688: Bug 1571470 - add scalabilityMode stat handling to WebrtcGlobal;r?dbaker.

Fri, Nov 7, 7:06 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D271650: Bug 1571470 - add svc status to aboutWebrtc;r?dbaker.

Fri, Nov 7, 7:06 AM

ng updated the diff for D255687: Bug 1571470 - add scalabilityMode to stats webidl;r?dbaker.

Fri, Nov 7, 7:05 AM · needs-testing-tag

ng updated the diff for D255686: Bug 1571470 - update RTCRtpParameters-scalability expectations to PASS;r?dbaker.

Fri, Nov 7, 7:04 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255685: Bug 1571470 - update RTCRtpParameters-scalability-h264 expectations to PASS;r?dbaker.

Fri, Nov 7, 7:03 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255684: Bug 1571470 - update RTCRtpParameters-scalability-vp9 expectations to PASS;r?dbaker.

Fri, Nov 7, 7:03 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255683: Bug 1571470 - update RTCRtpParameters-scalability-vp8 expectations to PASS;r?dbaker.

Fri, Nov 7, 7:01 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255682: Bug 1571470 - update RTCRtpParameters-scalability-av1 expectations to PASS;r?dbaker.

Fri, Nov 7, 6:58 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng added inline comments to D271656: Bug 1571470 - add SVC related failure metrics;r=bwc.

Fri, Nov 7, 6:31 AM · needs-testing-tag, Restricted Project

ng updated the diff for D271656: Bug 1571470 - add SVC related failure metrics;r=bwc.

Fri, Nov 7, 6:30 AM · needs-testing-tag, Restricted Project

ng updated the diff for D271655: Bug 1571470 - apply SVC configuration;r=dbaker,pehrsons.

Fri, Nov 7, 6:29 AM

ng added a reviewer for D271693: Bug 1571470 - add SVC setParameters failures;r=dbaker,bwc: bwc.

Fri, Nov 7, 4:58 AM · needs-testing-tag, Restricted Project

ng updated the diff for D230209: Bug 1571470 - expand setParameters mochitests with scalabilityMode;r?bwc.

Fri, Nov 7, 4:53 AM · testing-approved

ng added inline comments to D270794: Bug 1571470 - add wpt helper to check that SVC is used when requested;r=jib,pehrsons.

Fri, Nov 7, 4:20 AM

ng updated the diff for D270794: Bug 1571470 - add wpt helper to check that SVC is used when requested;r=jib,pehrsons.

Fri, Nov 7, 4:17 AM

ng accepted D271684: Bug 1577830: Ensure that sends for blobs and non-blobs are serialized. r?ng.

r+, with some nits/comments

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Fri, Nov 7, 12:45 AM · needs-testing-tag

Thu, Nov 6

ng requested review of D270794: Bug 1571470 - add wpt helper to check that SVC is used when requested;r=jib,pehrsons.

Thu, Nov 6, 10:28 PM

ng abandoned D271649: Bug 1571470 - add common ScalabilityInfo;r?dbaker.

Thu, Nov 6, 10:11 PM

ng abandoned D230345: WIP: Bug 1571470 - add dependency descriptor rtp header extension;r?pehrsons.

Thu, Nov 6, 10:09 PM

ng abandoned D230208: WIP: Bug 1571470 - add "webrtc" to MediaEncodingType;r?pehrsons.

Thu, Nov 6, 10:00 PM

ng created D271694: Bug 1571470 - add video conduit test for setting scalabilty mode;r=bwc.

Thu, Nov 6, 9:56 PM · testing-approved

ng created D271693: Bug 1571470 - add SVC setParameters failures;r=dbaker,bwc.

Thu, Nov 6, 9:54 PM · needs-testing-tag, Restricted Project

ng updated the diff for D271656: Bug 1571470 - add SVC related failure metrics;r=bwc.

Thu, Nov 6, 9:53 PM · needs-testing-tag, Restricted Project

ng updated the diff for D271655: Bug 1571470 - apply SVC configuration;r=dbaker,pehrsons.

Thu, Nov 6, 9:52 PM

ng updated the diff for D271654: Bug 1571470 - implement SVC getParameters;r=dbaker.

Thu, Nov 6, 9:51 PM

ng updated the diff for D271653: Bug 1571470 - implement SVC setParameters;r=dbaker.

Thu, Nov 6, 9:51 PM

ng updated the diff for D271652: Bug 1571470 - implement SVC addTransceiver;r=dbaker.

Thu, Nov 6, 9:50 PM

ng requested review of D271651: Bug 1571470 - add dd header extension for senders;r?bwc.

Thu, Nov 6, 9:50 PM · testing-approved

ng updated the diff for D230210: Bug 1571470 - add SVC mode fallback;r?dbaker.

Thu, Nov 6, 9:48 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255691: Bug 1571470 - add scalabilityMode stat handling to GetStats mochitest;r?dbaker.

Thu, Nov 6, 9:47 PM · testing-approved

ng updated the diff for D255690: Bug 1571470 - set scalabilityMode stat WPT expectation to PASS;r?dbaker.

Thu, Nov 6, 9:47 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255689: Bug 1571470 - fill in scalabilityMode stat in RTPSender;r?dbaker.

Thu, Nov 6, 9:43 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255688: Bug 1571470 - add scalabilityMode stat handling to WebrtcGlobal;r?dbaker.

Thu, Nov 6, 9:42 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D271650: Bug 1571470 - add svc status to aboutWebrtc;r?dbaker.

Thu, Nov 6, 9:41 PM

ng updated the diff for D255687: Bug 1571470 - add scalabilityMode to stats webidl;r?dbaker.

Thu, Nov 6, 9:40 PM · needs-testing-tag

ng updated the diff for D271649: Bug 1571470 - add common ScalabilityInfo;r?dbaker.

Thu, Nov 6, 9:39 PM

ng updated the diff for D255686: Bug 1571470 - update RTCRtpParameters-scalability expectations to PASS;r?dbaker.

Thu, Nov 6, 9:39 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255685: Bug 1571470 - update RTCRtpParameters-scalability-h264 expectations to PASS;r?dbaker.

Thu, Nov 6, 9:38 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255684: Bug 1571470 - update RTCRtpParameters-scalability-vp9 expectations to PASS;r?dbaker.

Thu, Nov 6, 9:37 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255683: Bug 1571470 - update RTCRtpParameters-scalability-vp8 expectations to PASS;r?dbaker.

Thu, Nov 6, 9:36 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255682: Bug 1571470 - update RTCRtpParameters-scalability-av1 expectations to PASS;r?dbaker.

Thu, Nov 6, 9:36 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng requested review of D230209: Bug 1571470 - expand setParameters mochitests with scalabilityMode;r?bwc.

Thu, Nov 6, 9:35 PM · testing-approved

ng updated the diff for D230207: Bug 1571470 - webrtc-svc vp9 wpt tests expect PASS;r?dbaker.

Thu, Nov 6, 9:33 PM · testing-approved

ng updated the diff for D230206: Bug 1571470 - add pref to enable svc mode for WebRTC;r?dbaker.

Thu, Nov 6, 9:20 PM · testing-approved

ng updated the diff for D230205: Bug 1571470 - add scalabiltyMode to RTCRtpEncodingParameters;r?dbaker.

Thu, Nov 6, 9:17 PM · needs-testing-tag

ng created D271662: Bug 1571470 - add common ScalabilityInfo;r?dbaker.

Thu, Nov 6, 7:21 PM

ng created D271656: Bug 1571470 - add SVC related failure metrics;r=bwc.

Thu, Nov 6, 7:07 PM · needs-testing-tag, Restricted Project

ng created D271655: Bug 1571470 - apply SVC configuration;r=dbaker,pehrsons.

Thu, Nov 6, 7:07 PM

ng created D271654: Bug 1571470 - implement SVC getParameters;r=dbaker.

Thu, Nov 6, 7:06 PM

ng created D271653: Bug 1571470 - implement SVC setParameters;r=dbaker.

Thu, Nov 6, 7:06 PM

ng created D271652: Bug 1571470 - implement SVC addTransceiver;r=dbaker.

Thu, Nov 6, 7:06 PM

ng created D271651: Bug 1571470 - add dd header extension for senders;r?bwc.

Thu, Nov 6, 7:05 PM · testing-approved

ng requested review of D230210: Bug 1571470 - add SVC mode fallback;r?dbaker.

Thu, Nov 6, 7:05 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255691: Bug 1571470 - add scalabilityMode stat handling to GetStats mochitest;r?dbaker.

Thu, Nov 6, 7:05 PM · testing-approved

ng updated the diff for D255690: Bug 1571470 - set scalabilityMode stat WPT expectation to PASS;r?dbaker.

Thu, Nov 6, 7:05 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255689: Bug 1571470 - fill in scalabilityMode stat in RTPSender;r?dbaker.

Thu, Nov 6, 7:05 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255688: Bug 1571470 - add scalabilityMode stat handling to WebrtcGlobal;r?dbaker.

Thu, Nov 6, 7:04 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng created D271650: Bug 1571470 - add svc status to aboutWebrtc;r?dbaker.

Thu, Nov 6, 7:04 PM

ng updated the diff for D255687: Bug 1571470 - add scalabilityMode to stats webidl;r?dbaker.

Thu, Nov 6, 7:04 PM · needs-testing-tag

ng created D271649: Bug 1571470 - add common ScalabilityInfo;r?dbaker.

Thu, Nov 6, 7:04 PM

ng updated the diff for D255686: Bug 1571470 - update RTCRtpParameters-scalability expectations to PASS;r?dbaker.

Thu, Nov 6, 7:03 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255685: Bug 1571470 - update RTCRtpParameters-scalability-h264 expectations to PASS;r?dbaker.

Thu, Nov 6, 7:03 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255684: Bug 1571470 - update RTCRtpParameters-scalability-vp9 expectations to PASS;r?dbaker.

Thu, Nov 6, 7:03 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255683: Bug 1571470 - update RTCRtpParameters-scalability-vp8 expectations to PASS;r?dbaker.

Thu, Nov 6, 7:03 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

ng updated the diff for D255682: Bug 1571470 - update RTCRtpParameters-scalability-av1 expectations to PASS;r?dbaker.

Thu, Nov 6, 7:03 PM · testing-exception-elsewhere (Please comment explaining where the tests are)