People valentin

valentin (Valentin Gosu)
User

Projects

cookie-reviewers
Group
necko-reviewers
Group

User Details

User Since: Nov 29 2017, 5:02 PM (415 w, 13 h)
Availability: Available
Review Queue: 0

Recent Activity
View All

Yesterday

valentin planned changes to D272223: WIP: Bug 1999659 - Test for non-ascii value in H3 header r=#necko.

Wed, Nov 12, 11:31 AM

valentin accepted D272174: Bug 1999554 - Automatically fix ESLint rule jsdoc/check-types for remaining code. r?#frontend-codestyle-reviewers!.

r+ for netwerk/

Wed, Nov 12, 9:25 AM · Restricted Project

Tue, Nov 11

valentin closed D272053: Bug 1999266 - Add test for speculative connect triggered by docshell mouseover r=#necko.

Tue, Nov 11, 1:28 PM · testing-approved

valentin closed D271984: Bug 1999266 - Extract PREDICT_LINK from predictor r=#necko.

Tue, Nov 11, 1:28 PM · testing-approved

valentin committed rFIREFOXAUTOLAND6c0a6af9662c: Bug 1999266 - Add test for speculative connect triggered by docshell mouseover… (authored by valentin).

Bug 1999266 - Add test for speculative connect triggered by docshell mouseover…

Tue, Nov 11, 1:28 PM

valentin committed rFIREFOXAUTOLAND521ac98b00eb: Bug 1999266 - Extract PREDICT_LINK from predictor r=necko-reviewers,jesup (authored by valentin).

Bug 1999266 - Extract PREDICT_LINK from predictor r=necko-reviewers,jesup

Tue, Nov 11, 1:28 PM

valentin planned changes to D271562: WIP: Bug 1998646 - Increase priority of DNSListenerProxy::OnLookupComplete runnables r=#necko.

Tue, Nov 11, 10:23 AM

valentin updated the diff for D271562: WIP: Bug 1998646 - Increase priority of DNSListenerProxy::OnLookupComplete runnables r=#necko.

Tue, Nov 11, 10:23 AM

valentin created D272125: Bug 1999454 - Enable fallback for essential services on Nightly r=#necko.

Tue, Nov 11, 8:34 AM · testing-exception-elsewhere (Please comment explaining where the tests are)

Mon, Nov 10

valentin added a comment to D271984: Bug 1999266 - Extract PREDICT_LINK from predictor r=#necko.

In D271984#9412978, @acreskey wrote:

Very interesting -- are we looking at enabling speculative connect on hover?

Mon, Nov 10, 8:28 PM · testing-approved

valentin updated the diff for D272053: Bug 1999266 - Add test for speculative connect triggered by docshell mouseover r=#necko.

fix lint

Mon, Nov 10, 7:08 PM · testing-approved

valentin created D272053: Bug 1999266 - Add test for speculative connect triggered by docshell mouseover r=#necko.

Mon, Nov 10, 6:25 PM · testing-approved

valentin updated the diff for D271984: Bug 1999266 - Extract PREDICT_LINK from predictor r=#necko.

Mon, Nov 10, 6:25 PM · testing-approved

valentin accepted D272041: Bug 1956923 - Warm up URL classifier earlier. r=valentin.

Mon, Nov 10, 6:25 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin committed rFIREFOXBETA8893737b3a4b: Bug 1998894 - Rename pathTemplate to masqueTemplate r=robwu,necko-reviewers… (authored by valentin).

Bug 1998894 - Rename pathTemplate to masqueTemplate r=robwu,necko-reviewers…

Mon, Nov 10, 3:43 PM

valentin committed rFIREFOXBETA8c5cb13f12e8: Bug 1998130 - Firefox should not include keep-alive in websocket Connection… (authored by valentin).

Bug 1998130 - Firefox should not include keep-alive in websocket Connection…

Mon, Nov 10, 3:42 PM

valentin committed rFIREFOXBETAfe3adabeb5c7: Bug 1958291 - Make sure WebTransport CYCLE_COLLECTION calls… (authored by valentin).

Bug 1958291 - Make sure WebTransport CYCLE_COLLECTION calls…

Mon, Nov 10, 3:40 PM

valentin committed rFIREFOXBETA6847e4953fdb: Bug 1998356 - Vendor urlpattern 0.4.1 r=necko-reviewers,supply-chain-reviewers… (authored by valentin).

Bug 1998356 - Vendor urlpattern 0.4.1 r=necko-reviewers,supply-chain-reviewers…

Mon, Nov 10, 3:32 PM

valentin committed rFIREFOXBETAd4a1bafec5e8: Bug 1998271 - URLPattern "*" doesn't match letter "x" r=necko-reviewers,jesup (authored by valentin).

Bug 1998271 - URLPattern "*" doesn't match letter "x" r=necko-reviewers,jesup

Mon, Nov 10, 3:32 PM

valentin committed rFIREFOXBETA27f5ac699af0: Bug 1998271 - Add test for urlpattern with x in path r=necko-reviewers,jesup (authored by valentin).

Bug 1998271 - Add test for urlpattern with x in path r=necko-reviewers,jesup

Mon, Nov 10, 3:32 PM

valentin committed rFIREFOXBETA5e8c981c3d4b: Bug 1849304 - Disable intermittent doh browser mochitests on socket process… (authored by valentin).

Bug 1849304 - Disable intermittent doh browser mochitests on socket process…

Mon, Nov 10, 3:30 PM

valentin committed rFIREFOXBETA5026f38e37fa: Bug 1896255 - Increase default timeout to shutdown DNS threads to 5 seconds… (authored by valentin).

Bug 1896255 - Increase default timeout to shutdown DNS threads to 5 seconds…

Mon, Nov 10, 3:30 PM

valentin committed rFIREFOXBETA305f1022d1e6: Bug 1940027 - Test r=necko-reviewers,kershaw (authored by valentin).

Bug 1940027 - Test r=necko-reviewers,kershaw

Mon, Nov 10, 3:29 PM

valentin committed rFIREFOXBETA32d630146cd9: Bug 1997895 - Temporarily back out support for about and data URLs with… (authored by valentin).

Bug 1997895 - Temporarily back out support for about and data URLs with…

Mon, Nov 10, 3:26 PM

valentin committed rFIREFOXBETA67155069de2a: Bug 1992996 - Stop polling UDP socket when H3 session is closed r=mxinden (authored by valentin).

Bug 1992996 - Stop polling UDP socket when H3 session is closed r=mxinden

Mon, Nov 10, 3:26 PM

valentin committed rFIREFOXBETAdc247645dfd3: Bug 1992996 - Properly handle UDP errors in Http3ConnectProxyServer r=mxinden (authored by valentin).

Bug 1992996 - Properly handle UDP errors in Http3ConnectProxyServer r=mxinden

Mon, Nov 10, 3:26 PM

valentin committed rFIREFOXBETAf289b76df38b: Bug 1849304 - Disable intermittent browser_trrSelection_disable.js on socket… (authored by valentin).

Bug 1849304 - Disable intermittent browser_trrSelection_disable.js on socket…

Mon, Nov 10, 3:21 PM

valentin committed rFIREFOXBETAe9af221706b4: Bug 1988783 - Make sure authentication prompt suspends channel by calling… (authored by valentin).

Bug 1988783 - Make sure authentication prompt suspends channel by calling…

Mon, Nov 10, 2:53 PM

valentin committed rFIREFOXBETA1015047dbd47: Bug 1995925 - Make gtests use env from mach r=ahal (authored by valentin).

Bug 1995925 - Make gtests use env from mach r=ahal

Mon, Nov 10, 2:51 PM

valentin committed rFIREFOXBETAaf26e0d427cd: Bug 1984105 - Disable Public to Private network LNA checks for Captive Portals… (authored by valentin).

Bug 1984105 - Disable Public to Private network LNA checks for Captive Portals…

Mon, Nov 10, 2:51 PM

valentin committed rFIREFOXBETA3be3c8e367ce: Bug 1984105 - Make sure AllowedToConnectToIpAddressSpace checks pending… (authored by valentin).

Bug 1984105 - Make sure AllowedToConnectToIpAddressSpace checks pending…

Mon, Nov 10, 2:51 PM

valentin committed rFIREFOXBETA4afd0a907716: Bug 1995267 - Workaround for 1993248 - mark PRFileDesc nonblocking to avoid… (authored by valentin).

Bug 1995267 - Workaround for 1993248 - mark PRFileDesc nonblocking to avoid…

Mon, Nov 10, 2:42 PM

valentin committed rFIREFOXBETAd90faf32c738: Bug 1992512 - Check retargetable listener succeeds CheckListenerChain when… (authored by valentin).

Bug 1992512 - Check retargetable listener succeeds CheckListenerChain when…

Mon, Nov 10, 2:40 PM

valentin committed rFIREFOXBETAb5306fec8426: Bug 1995053 - Add documentation for NodeServer.sys.mjs r=necko-reviewers,jesup (authored by valentin).

Bug 1995053 - Add documentation for NodeServer.sys.mjs r=necko-reviewers,jesup

Mon, Nov 10, 2:37 PM

valentin committed rFIREFOXBETA913290f97267: Bug 1995053 - Make each call to NodeServer.execute have a unique ID r=necko… (authored by valentin).

Bug 1995053 - Make each call to NodeServer.execute have a unique ID r=necko…

Mon, Nov 10, 2:37 PM

valentin committed rFIREFOXBETA904d956b7b04: Bug 1988355 - remove unused nsIHttpChannel.isPrivateResponse. r=valentin,necko… (authored by hedgefog.98).

Bug 1988355 - remove unused nsIHttpChannel.isPrivateResponse. r=valentin,necko…

Mon, Nov 10, 2:33 PM

valentin committed rFIREFOXBETA060da280e4ff: Bug 1994165 - Disable test_ext_proxy_http3.js to avoid frequent intermittent… (authored by valentin).

Bug 1994165 - Disable test_ext_proxy_http3.js to avoid frequent intermittent…

Mon, Nov 10, 2:33 PM

valentin committed rFIREFOXBETA2340085650ef: Bug 1995068 - Avoid null pointer deref in EventSourceImpl… (authored by valentin).

Bug 1995068 - Avoid null pointer deref in EventSourceImpl…

Mon, Nov 10, 2:31 PM

valentin committed rFIREFOXBETA1dc51d24c3e0: Bug 400264 - Remove unused nsIDNKitInterface.h r=valentin,necko-reviewers… (authored by hedgefog.98).

Bug 400264 - Remove unused nsIDNKitInterface.h r=valentin,necko-reviewers…

Mon, Nov 10, 2:30 PM

valentin committed rFIREFOXBETA73e21f505e8f: Bug 1994728 - Also fix dns_service_wrap test r=necko-reviewers,kershaw (authored by valentin).

Bug 1994728 - Also fix dns_service_wrap test r=necko-reviewers,kershaw

Mon, Nov 10, 2:17 PM

valentin committed rFIREFOXBETA9eadb586ca75: Bug 1966494 - Make sure channels waiting for cache entry aren't blocked by… (authored by valentin).

Bug 1966494 - Make sure channels waiting for cache entry aren't blocked by…

Mon, Nov 10, 2:14 PM

valentin committed rFIREFOXBETA6c989f8755f6: Bug 1966494 - Add browser mochitest to test fetch after suspend in http-on… (authored by jdescottes).

Bug 1966494 - Add browser mochitest to test fetch after suspend in http-on…

Mon, Nov 10, 2:14 PM

valentin committed rFIREFOXBETA7dc370bd78d1: Bug 1994728 - Fix test_dns_service.js to mock the DNS response r=necko… (authored by valentin).

Bug 1994728 - Fix test_dns_service.js to mock the DNS response r=necko…

Mon, Nov 10, 2:14 PM

valentin committed rFIREFOXBETA15d2393fd4d8: Bug 1433890 - Test that webextension dir listing does not contain file or jar… (authored by valentin).

Bug 1433890 - Test that webextension dir listing does not contain file or jar…

Mon, Nov 10, 2:13 PM

valentin committed rFIREFOXBETAce12fe1250a1: Bug 1433890 - Do not use the webext channel's real URL in nsIndexedToHTML… (authored by valentin).

Bug 1433890 - Do not use the webext channel's real URL in nsIndexedToHTML…

Mon, Nov 10, 2:13 PM

valentin committed rFIREFOXBETAd4789cb49068: Bug 1989918 - Add warning when dispatch from DNSListenerProxy::OnLookupComplete… (authored by valentin).

Bug 1989918 - Add warning when dispatch from DNSListenerProxy::OnLookupComplete…

Mon, Nov 10, 2:03 PM

valentin created D271984: Bug 1999266 - Extract PREDICT_LINK from predictor r=#necko.

Mon, Nov 10, 1:59 PM · testing-approved

valentin accepted D271532: Bug 1995869: Initialize DNS earlier in IOService init r=#necko-reviewers!.

Mon, Nov 10, 1:56 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin created D271979: Bug 1999247 - Make NEL implementation use ReportDeliver::Fetch to enqueue report r=#necko.

Mon, Nov 10, 1:29 PM · testing-approved

valentin created D271978: Bug 1999245 - Add ReportingHeader::GetEndpointForReportIncludeSubdomains r=sefeng.

Mon, Nov 10, 1:29 PM

valentin accepted D271909: Bug 1856418 - Remove old clear data dialog and privacy.sanitize.useOldClearHistoryDialog preference. r?manuel.

r+ for netwerk/

Mon, Nov 10, 7:59 AM

valentin accepted D271871: Bug 1998926 - Part 1: Add nsICacheInfoChannel.hasCacheEntry. r?valentin!.

Mon, Nov 10, 7:58 AM · testing-approved

valentin accepted D271872: Bug 1998926 - Part 2: Remove IsFromCache requirements from GetCacheEntryId. r?valentin!.

Mon, Nov 10, 7:57 AM · testing-approved

Sun, Nov 9

valentin closed D271748: Bug 1998894 - Rename pathTemplate to masqueTemplate r=#necko,robwu.

Sun, Nov 9, 10:31 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin committed rFIREFOXAUTOLAND8893737b3a4b: Bug 1998894 - Rename pathTemplate to masqueTemplate r=robwu,necko-reviewers… (authored by valentin).

Bug 1998894 - Rename pathTemplate to masqueTemplate r=robwu,necko-reviewers…

Sun, Nov 9, 10:31 PM

valentin updated the diff for D271748: Bug 1998894 - Rename pathTemplate to masqueTemplate r=#necko,robwu.

Sun, Nov 9, 7:00 PM · testing-exception-unchanged (Doesn't change behavior for users)

Sat, Nov 8

valentin closed D271206: Bug 1998130 - Firefox should not include keep-alive in websocket Connection header r=#necko.

Sat, Nov 8, 10:14 AM · needs-testing-tag

valentin committed rFIREFOXAUTOLAND8c5cb13f12e8: Bug 1998130 - Firefox should not include keep-alive in websocket Connection… (authored by valentin).

Bug 1998130 - Firefox should not include keep-alive in websocket Connection…

Sat, Nov 8, 10:14 AM

Fri, Nov 7

valentin closed D271550: Bug 1958291 - Make sure WebTransport CYCLE_COLLECTION calls UNLINK_PRESERVED_WRAPPER r=#necko.

Fri, Nov 7, 3:56 PM · testing-approved

valentin committed rFIREFOXAUTOLANDfe3adabeb5c7: Bug 1958291 - Make sure WebTransport CYCLE_COLLECTION calls… (authored by valentin).

Bug 1958291 - Make sure WebTransport CYCLE_COLLECTION calls…

Fri, Nov 7, 3:56 PM

valentin added 1 blocking reviewer(s) for D271748: Bug 1998894 - Rename pathTemplate to masqueTemplate r=#necko,robwu: robwu.

I'll defer to Rob as to whether we actually want to land this.
The :path is defined to possibly include query params.
But that conflicts with the URL path. Not sure if we just want documentation for the pathTemplate member, or to rename it to avoid misunderstandings.

Fri, Nov 7, 3:08 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin created D271748: Bug 1998894 - Rename pathTemplate to masqueTemplate r=#necko,robwu.

Fri, Nov 7, 9:54 AM · testing-exception-unchanged (Doesn't change behavior for users)

valentin added inline comments to D271532: Bug 1995869: Initialize DNS earlier in IOService init r=#necko-reviewers!.

Fri, Nov 7, 8:41 AM · testing-exception-unchanged (Doesn't change behavior for users)

valentin accepted D271488: Bug 1997949 - Add a test for Fenix DoH performance during concurrent DNS resolutions and HTTP requests r=#necko-reviewers,sparky.

Great stuff. Thanks!

Fri, Nov 7, 8:36 AM · testing-exception-unchanged (Doesn't change behavior for users)

valentin accepted D267450: Bug 1992479 - Add profiler markers for dns resolution r=#necko-reviewers.

In D267450#9398011, @acreskey wrote:

@valentin -- what do you think of removing the nsHostResolver::CompleteLookupLocked and nsHostResolver::ResolveHost markers, as the new ones now include the additional fields?
I can re-add if there's value in those.

Fri, Nov 7, 8:21 AM · testing-exception-unchanged (Doesn't change behavior for users)

Thu, Nov 6

valentin created D271583: Bug 1915371 - Part 4: Make test_http_auth_cache mochitest automatically accept password prompt r=#necko.

Thu, Nov 6, 1:22 PM · testing-approved

valentin created D271582: Bug 1915371 - Part 3: Fix auth bugs r=#necko.

Thu, Nov 6, 1:22 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin requested review of D244063: Bug 1915371 - Part 2: Add a mochitest for HTTP Authentication Cache XPIDL r=valentin,edgul.

Thu, Nov 6, 1:21 PM · testing-approved

valentin requested review of D243723: Bug 1915371 - Part 1: Add XPIDL interface for HTTP Authentication Cache r=valentin,edgul.

Thu, Nov 6, 1:21 PM · testing-exception-elsewhere (Please comment explaining where the tests are)

valentin updated the uplift request field for D271569: Bug 1998271 - URLPattern "*" doesn't match letter "x".

Thu, Nov 6, 12:09 PM

valentin created D271569: Bug 1998271 - URLPattern "*" doesn't match letter "x".

Thu, Nov 6, 12:09 PM

valentin created D271568: Bug 1998271 - Add test for urlpattern with x in path.

Thu, Nov 6, 12:09 PM

valentin planned changes to D271562: WIP: Bug 1998646 - Increase priority of DNSListenerProxy::OnLookupComplete runnables r=#necko.

Thu, Nov 6, 10:23 AM

valentin created D271550: Bug 1958291 - Make sure WebTransport CYCLE_COLLECTION calls UNLINK_PRESERVED_WRAPPER r=#necko.

Thu, Nov 6, 9:25 AM · testing-approved

valentin accepted D271532: Bug 1995869: Initialize DNS earlier in IOService init r=#necko-reviewers!.

Thu, Nov 6, 7:58 AM · testing-exception-unchanged (Doesn't change behavior for users)

Wed, Nov 5

valentin closed D271367: Bug 1998356 - Vendor urlpattern 0.4.1 r=#necko.

Wed, Nov 5, 6:22 PM · testing-approved

valentin closed D271361: Bug 1998271 - URLPattern "*" doesn't match letter "x" r=#necko.

Wed, Nov 5, 6:22 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin committed rFIREFOXAUTOLAND6847e4953fdb: Bug 1998356 - Vendor urlpattern 0.4.1 r=necko-reviewers,supply-chain-reviewers… (authored by valentin).

Bug 1998356 - Vendor urlpattern 0.4.1 r=necko-reviewers,supply-chain-reviewers…

Wed, Nov 5, 6:22 PM

valentin closed D271360: Bug 1998271 - Add test for urlpattern with x in path r=#necko.

Wed, Nov 5, 6:22 PM · testing-approved

valentin committed rFIREFOXAUTOLAND27f5ac699af0: Bug 1998271 - Add test for urlpattern with x in path r=necko-reviewers,jesup (authored by valentin).

Bug 1998271 - Add test for urlpattern with x in path r=necko-reviewers,jesup

Wed, Nov 5, 6:22 PM

valentin committed rFIREFOXAUTOLANDd4a1bafec5e8: Bug 1998271 - URLPattern "*" doesn't match letter "x" r=necko-reviewers,jesup (authored by valentin).

Bug 1998271 - URLPattern "*" doesn't match letter "x" r=necko-reviewers,jesup

Wed, Nov 5, 6:22 PM

valentin added a comment to D271367: Bug 1998356 - Vendor urlpattern 0.4.1 r=#necko.

In D271367#9389158, @jesup wrote:

We should poke upstream about the unmaintained/archived dependencies (open an issue if there isn't one)

Wed, Nov 5, 2:34 PM · testing-approved

valentin accepted D271018: Bug 1997862 - Make nsCOMPtr default constructor constinit-compatible r=emilio!.

Wed, Nov 5, 1:28 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin created D271367: Bug 1998356 - Vendor urlpattern 0.4.1 r=#necko.

Wed, Nov 5, 9:56 AM · testing-approved

valentin updated the diff for D271361: Bug 1998271 - URLPattern "*" doesn't match letter "x" r=#necko.

Wed, Nov 5, 9:56 AM · testing-exception-unchanged (Doesn't change behavior for users)

valentin closed D271048: Bug 1849304 - Disable intermittent doh browser mochitests on socket process r=#necko.

Wed, Nov 5, 9:05 AM · testing-exception-unchanged (Doesn't change behavior for users)

valentin committed rFIREFOXAUTOLAND5e8c981c3d4b: Bug 1849304 - Disable intermittent doh browser mochitests on socket process… (authored by valentin).

Bug 1849304 - Disable intermittent doh browser mochitests on socket process…

Wed, Nov 5, 9:05 AM

valentin created D271361: Bug 1998271 - URLPattern "*" doesn't match letter "x" r=#necko.

Wed, Nov 5, 9:01 AM · testing-exception-unchanged (Doesn't change behavior for users)

valentin created D271360: Bug 1998271 - Add test for urlpattern with x in path r=#necko.

Wed, Nov 5, 9:01 AM · testing-approved

valentin closed D271192: Bug 1896255 - Increase default timeout to shutdown DNS threads to 5 seconds r=#necko.

Wed, Nov 5, 8:26 AM · testing-exception-unchanged (Doesn't change behavior for users)

valentin committed rFIREFOXAUTOLAND5026f38e37fa: Bug 1896255 - Increase default timeout to shutdown DNS threads to 5 seconds… (authored by valentin).

Bug 1896255 - Increase default timeout to shutdown DNS threads to 5 seconds…

Wed, Nov 5, 8:26 AM

valentin accepted D269262: Bug 1971428 - Convert DoH to config-based prefs - r=valentin!,#recomp-reviewers!.

Wed, Nov 5, 8:22 AM · testing-approved

Tue, Nov 4

valentin closed D234674: Bug 1940027 - Test r=#necko.

Tue, Nov 4, 9:41 PM · testing-approved

valentin committed rFIREFOXAUTOLAND305f1022d1e6: Bug 1940027 - Test r=necko-reviewers,kershaw (authored by valentin).

Bug 1940027 - Test r=necko-reviewers,kershaw

Tue, Nov 4, 9:41 PM

valentin accepted D271240: Bug 1997552: Mark Compression Dictionary WPTs as passing in Nightly only for now r=#necko-reviewers!.

Alternatively we could set the pref to enable dictionary transport in testing/web-platform/meta/fetch/compression-dictionary/__dir__.ini

Tue, Nov 4, 5:10 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin accepted D269262: Bug 1971428 - Convert DoH to config-based prefs - r=valentin!,#recomp-reviewers!.

Tue, Nov 4, 2:09 PM · testing-approved

valentin updated the diff for D199333: Bug 1849686 - Add http-on-dispatching-transaction event r=#necko.

Tue, Nov 4, 1:59 PM · testing-exception-unchanged (Doesn't change behavior for users)

valentin updated the diff for D234674: Bug 1940027 - Test r=#necko.

Tue, Nov 4, 1:51 PM · testing-approved

valentin updated the diff for D234674: Bug 1940027 - Test r=#necko.

rebase

Tue, Nov 4, 1:45 PM · testing-approved

valentin updated the diff for D271048: Bug 1849304 - Disable intermittent doh browser mochitests on socket process r=#necko.

Tue, Nov 4, 1:41 PM · testing-exception-unchanged (Doesn't change behavior for users)