Page MenuHomePhabricator

data-classification-unnecessaryTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Used to flag revisions that add/modify/remove files related to data collection, but do not add/modify actual data collection. See https://wiki.mozilla.org/Data_Collection#Adding_or_Modifying_Data_Collection for details.

Recent Activity

Yesterday

agoloman added a reverting change for D272244: Bug 1990006 - Fix `send_in_pings` pointing to old gecko-trace ping r=jari: rFIREFOXAUTOLAND2dc05bedeff3: Revert "Bug 1990006 - Fix `send_in_pings` pointing to old gecko-trace ping….
Wed, Nov 12, 6:31 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
agoloman reopened D272244: Bug 1990006 - Fix `send_in_pings` pointing to old gecko-trace ping r=jari.
Wed, Nov 12, 6:31 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
mvanstraten closed D272244: Bug 1990006 - Fix `send_in_pings` pointing to old gecko-trace ping r=jari.
Wed, Nov 12, 6:18 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
mvanstraten edited projects for D272244: Bug 1990006 - Fix `send_in_pings` pointing to old gecko-trace ping r=jari, added: data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users); removed needs-testing-tag, Restricted Project.
Wed, Nov 12, 4:32 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
afranchuk updated the diff for D265514: Bug 1989439 p6 - Remove unused Glean metrics. r=gsvelto.
Wed, Nov 12, 2:05 PM · data-classification-unnecessary, needs-testing-tag

Mon, Nov 10

[email protected] <[email protected]> closed D271745: Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r?#frontend-codestyle-reviewers!.
Mon, Nov 10, 9:45 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
Roger closed D272002: Bug 1994722 - Remove shortcut suggestions switch from search settings..
Mon, Nov 10, 9:24 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
Standard8 updated the diff for D271745: Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r?#frontend-codestyle-reviewers!.

Rebase & address comment

Mon, Nov 10, 5:57 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
mtigley accepted D271745: Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r?#frontend-codestyle-reviewers!.
Mon, Nov 10, 5:54 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
Standard8 added a comment to D271745: Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r?#frontend-codestyle-reviewers!.

Not sure how convinced I am about this, but primarily because this means more stuff gets automatically formatted (and I guess having 0 lines between intro + first tag would involve even more changes?), I guess it's OK.

Mon, Nov 10, 5:52 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
flod accepted D272002: Bug 1994722 - Remove shortcut suggestions switch from search settings..
Mon, Nov 10, 4:37 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
petru accepted D272002: Bug 1994722 - Remove shortcut suggestions switch from search settings..
Mon, Nov 10, 3:41 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
Roger edited projects for D272002: Bug 1994722 - Remove shortcut suggestions switch from search settings., added: data-classification-unnecessary; removed Restricted Project.
Mon, Nov 10, 3:40 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
afranchuk updated the diff for D265514: Bug 1989439 p6 - Remove unused Glean metrics. r=gsvelto.
Mon, Nov 10, 2:30 PM · data-classification-unnecessary, needs-testing-tag
sparky accepted D271745: Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r?#frontend-codestyle-reviewers!.
Mon, Nov 10, 1:53 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
mconley accepted D271745: Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r?#frontend-codestyle-reviewers!.

r=me for newtab changes. Thanks!

Mon, Nov 10, 12:59 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
Gijs edited projects for D271745: Bug 1998787 - Automatic fixes for enabling ESLint jsdoc/tag-line rule everywhere. r?#frontend-codestyle-reviewers!, added: data-classification-unnecessary; removed Restricted Project.
Mon, Nov 10, 11:24 AM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)

Wed, Nov 5

daisuke closed D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment.
Wed, Nov 5, 8:16 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
daisuke closed D271336: Bug 1996153: Remove browser.urlbar.suggest.quicksuggest.nonsponsored from TelemetryEnvironment.
Wed, Nov 5, 8:16 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
daisuke added a comment to D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment.

Thanks!

Wed, Nov 5, 8:13 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
daisuke added a comment to D271336: Bug 1996153: Remove browser.urlbar.suggest.quicksuggest.nonsponsored from TelemetryEnvironment.

Thanks!

Wed, Nov 5, 8:13 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
adw accepted D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment.

Thanks!

Wed, Nov 5, 8:02 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
nordzilla closed D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!.
Wed, Nov 5, 6:52 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
chutten accepted D271336: Bug 1996153: Remove browser.urlbar.suggest.quicksuggest.nonsponsored from TelemetryEnvironment.

Happy to r+ data removal

Wed, Nov 5, 4:32 PM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
chutten accepted D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment.

Happy to r+ data removal

Wed, Nov 5, 4:31 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
nordzilla updated the diff for D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!.
Wed, Nov 5, 1:37 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
NarcisB added a reverting change for D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!: rFIREFOXAUTOLAND9ec9c60ee6dd: Revert "Bug 1997612 - Add Translations telemetry rate-limit tests….
Wed, Nov 5, 10:34 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
NarcisB added a reverting change for D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!: rFIREFOXAUTOLANDc780e9bece16: Revert "Bug 1997612 - Add Translations telemetry rate-limit tests….
Wed, Nov 5, 9:52 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
NarcisB reopened D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!.
Wed, Nov 5, 9:52 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
Harbormaster failed remote builds in B870008: Diff 1150440 for D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment!
Wed, Nov 5, 7:18 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
reviewbot added a comment to D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment.

The analysis task source-test-doc-upload failed, but we could not detect any defect.
Please check this task manually.

Wed, Nov 5, 7:18 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
daisuke updated the diff for D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment.
Wed, Nov 5, 6:56 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
Harbormaster failed remote builds in B870000: Diff 1150430 for D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment!
Wed, Nov 5, 5:56 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
reviewbot added a comment to D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment.

The analysis task source-test-doc-upload failed, but we could not detect any defect.
Please check this task manually.

Wed, Nov 5, 5:56 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
daisuke added a reviewer for D271346: Bug 1996169: Remove browser.urlbar.quicksuggest.dataCollection.enabled from TelemetryEnvironment: adw.

The try looks no problem.
https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Csuccess%2Cretry%2Cusercancel%2Crunnable&revision=a36bcad4814a83420134a85fdea557042fd4d7ef

Wed, Nov 5, 5:45 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
daisuke added a comment to D271336: Bug 1996153: Remove browser.urlbar.suggest.quicksuggest.nonsponsored from TelemetryEnvironment.

The try also looks no problem.
https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Csuccess%2Cretry%2Cusercancel%2Crunnable&revision=b8a183e892f4c2d8b338680b0f4cd31f15b50ecc

Wed, Nov 5, 5:42 AM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)
adw accepted D271336: Bug 1996153: Remove browser.urlbar.suggest.quicksuggest.nonsponsored from TelemetryEnvironment.

Lgtm, thanks! data-classification-unnecessary: This removes some telemetry.

Wed, Nov 5, 3:46 AM · data-classification-unnecessary, testing-exception-unchanged (Doesn't change behavior for users)

Tue, Nov 4

nordzilla closed D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!.
Tue, Nov 4, 9:54 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
npypchenko closed D270976: Bug 1966241 - Remove Fakespot experiment code r=#home-newtab-reviewers!.
Tue, Nov 4, 9:41 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
gregtatum accepted D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!.
Tue, Nov 4, 7:33 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
afranchuk updated the diff for D265514: Bug 1989439 p6 - Remove unused Glean metrics. r=gsvelto.
Tue, Nov 4, 5:30 PM · data-classification-unnecessary, needs-testing-tag
afranchuk updated the diff for D265514: Bug 1989439 p6 - Remove unused Glean metrics. r=gsvelto.
Tue, Nov 4, 5:09 PM · data-classification-unnecessary, needs-testing-tag

Mon, Nov 3

dmcintosh closed D270720: Bug 1997391 - Part 2: Add internalReason and specific tests for archive and restore disable statuses. r=cdupuis,#backup-reviewers.
Mon, Nov 3, 11:36 PM · testing-approved, data-classification-unnecessary
cdupuis edited projects for D270720: Bug 1997391 - Part 2: Add internalReason and specific tests for archive and restore disable statuses. r=cdupuis,#backup-reviewers, added: testing-approved; removed needs-testing-tag.
Mon, Nov 3, 8:46 PM · testing-approved, data-classification-unnecessary
nordzilla updated the diff for D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!.
Mon, Nov 3, 3:46 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
willdurand accepted D271063: Bug 1994595 - Renew addons manager install/manage and storage errors events. r=willdurand!.
Mon, Nov 3, 3:35 PM · Restricted Project, testing-exception-unchanged (Doesn't change behavior for users)
janerik accepted D270976: Bug 1966241 - Remove Fakespot experiment code r=#home-newtab-reviewers!.

r+ for metric removal.

Mon, Nov 3, 2:23 PM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
nordzilla updated the diff for D270875: Bug 1997612 - Remove flow_id from translations_performance r=#translations-reviewers!.
Mon, Nov 3, 11:50 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
reemhamz accepted D270976: Bug 1966241 - Remove Fakespot experiment code r=#home-newtab-reviewers!.
Mon, Nov 3, 1:23 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary
npypchenko edited projects for D270976: Bug 1966241 - Remove Fakespot experiment code r=#home-newtab-reviewers!, added: data-classification-unnecessary; removed Restricted Project.
Mon, Nov 3, 1:15 AM · testing-exception-unchanged (Doesn't change behavior for users), data-classification-unnecessary