shebang for tcl postgresql modules - Mailing list pgsql-hackers

From Jozef Mlich
Subject shebang for tcl postgresql modules
Date
Msg-id [email protected]
Whole thread Raw
Responses Re: shebang for tcl postgresql modules
List pgsql-hackers
Dear hackers,

I would like to ask you if is there any reason to pretend tcl scripts
are shell scripts?

I am speaking namely about these files

http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_delmod.in;hb=HEAD
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_listmod.in;hb=HEAD
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_loadmod.in;hb=HEAD


Here is the part of code I am speaking about:

#! /bin/sh
# Start tclsh \
exec @TCLSH@ "$0" "$@"

instead of
#! /usr/bin/tclsh

or
#! @TCLSH@

I am asking because our test suite is triggering errors on this [1]. In
this case, it seems easier to modify code rather then test suite. Please
apply attached patch if there is no particular reason for use
of /bin/sh.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1199464


--
Jozef Mlich <[email protected]>
Associate Software Engineer - EMEA ENG Developer Experience
Mobile: +420 604 217 719
http://cz.redhat.com/
Red Hat, Inc.

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Turning off HOT/Cleanup sometimes
Next
From: Amit Langote
Date:
Subject: Re: Parallel Seq Scan