Re: Patch queue triage - Mailing list pgsql-hackers

From Pavan Deolasee
Subject Re: Patch queue triage
Date
Msg-id [email protected]
Whole thread Raw
In response to Patch queue triage  (Tom Lane <[email protected]>)
Responses Re: Patch queue triage
List pgsql-hackers

On 5/2/07, Tom Lane <[email protected]> wrote:


* [PATCHES] HOT Patch - Ready for review  /Pavan Deolasee/

This needs a *lot* of review.  Can we break it down into more manageable
chunks?  I'm not sure that anyone's got a full grasp of the implications
of this patch, and that's a scary thought.


Sure, we can do that. I actually did that when I posted the
incremental versions of the HOT-patch, each version implementing
the next big chunk of the code. I can reverse engineer that again.

When I do that, should I just break the patch into logical pieces without
worrying about whether each piece alone builds/works correcttly ?
Or should I try to make each piece complete ? I know the second
would be a preferred way, but it would be more work. But if that can
considerably ease review process, I would do that by all means.
In any case, there will be dependecies amongst the patches.

I am on leave today, so would start on this tomorrow.

Thanks,
Pavan


--

EnterpriseDB     http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: "Pavan Deolasee"
Date:
Subject: Re: Patch queue triage
Next
From: Oleg Bartunov
Date:
Subject: Re: Patch queue triage