Re: Setting -Werror in CFLAGS - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Setting -Werror in CFLAGS
Date
Msg-id [email protected]
Whole thread Raw
In response to Re: Setting -Werror in CFLAGS  (Robert Haas <[email protected]>)
Responses Re: Setting -Werror in CFLAGS
List pgsql-hackers
On 04.01.2012 20:44, Robert Haas wrote:
> On Tue, Jan 3, 2012 at 9:23 PM, Tom Lane<[email protected]>  wrote:
>> Robert Haas<[email protected]>  writes:
>>> On Tue, Jan 3, 2012 at 7:39 PM, Peter Geoghegan<[email protected]>  wrote:
>>>> Yes, I know that these only appeared in GCC 4.6+ and as such are a
>>>> relatively recent phenomenon, but there has been some effort to
>>>> eliminate them, and if I could get a non-hacked -Werror build I'd feel
>>>> happy enough about excluding them as already outlined.
>>
>>> I just do this:
>>> echo COPT=-Werror>  src/Makefile.custom
>>> ...which seems to work reasonably well.
>>
>> I see no point in -Werror whatsoever.  If you aren't examining the make
>> output for warnings, you're not following proper development practice
>> IMO.
>
> I find -Werror to be a convenient way to examine the output for
> warnings.  Otherwise they scroll off the screen.  Yeah, I could save
> the output to a file and grep it afterwards, but that seems less
> convenient.  I'm clearly not the only one doing it this way, since
> src/backend/parser/gram.o manually sticks in -Wno-error...

I use "make -s".

--   Heikki Linnakangas  EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: Page Checksums + Double Writes
Next
From: Andrew Dunstan
Date:
Subject: Re: Setting -Werror in CFLAGS