Re: lock_timeout GUC patch - Mailing list pgsql-hackers

From Robert Haas
Subject Re: lock_timeout GUC patch
Date
Msg-id [email protected]
Whole thread Raw
In response to Re: lock_timeout GUC patch  (Boszormenyi Zoltan <[email protected]>)
Responses Re: lock_timeout GUC patch
List pgsql-hackers
2010/1/20 Boszormenyi Zoltan <[email protected]>:
> Attached with the proposed modification to lift the portability concerns.
> Fixed the missing check for get_rel_name() and one typo ("transation")
> Introduced checks for semtimedop() and sem_timedwait() in configure.in
> and USE_LOCK_TIMEOUT in port.h depending on
> HAVE_DECL_SEMTIMEDOP || HAVE_DECL_SEM_TIMEDWAIT || WIN32
> Introduced assign_lock_timeout() GUC validator function that allows
> setting the value only from the wired-in-default (0) or from SET statements.
>
> Comments?

I think that it is a very bad idea to implement this feature in a way
that is not 100% portable.

...Robert


pgsql-hackers by date:

Previous
From: [email protected]
Date:
Subject: Re: Bloom filters bloom filters bloom filters
Next
From: Tom Lane
Date:
Subject: Re: lock_timeout GUC patch