Re: review: More frame options in window functions - Mailing list pgsql-hackers

From Hitoshi Harada
Subject Re: review: More frame options in window functions
Date
Msg-id [email protected]
Whole thread Raw
In response to review: More frame options in window functions  (Pavel Stehule <[email protected]>)
List pgsql-hackers
2010/1/14 Pavel Stehule <[email protected]>:
> Hello
>
> I looked on Hitoshi's patch - and my result is:

Thanks for the review. I've found another crash today and attached is
fixed version. The case is:

SELECT four, sum(ten) over (PARTITION BY four ORDER BY four RANGE 1
PRECEDING) FROM tenk1 WHERE unique1 < 10;

The planner recognizes windowagg->ordNumCol as 0 for optimization, but
RANGE offset cases should really have interest on that value as the
syntax says.

Regards,


--
Hitoshi Harada

Attachment

pgsql-hackers by date:

Previous
From: Chris Browne
Date:
Subject: Re: Add .gitignore files to CVS?
Next
From: David Fetter
Date:
Subject: Re: mailing list archiver chewing patches