-
Notifications
You must be signed in to change notification settings - Fork 216
feat(surveys): emit survey abandoned event #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
packages/browser/src/extensions/surveys/surveys-extension-utils.tsx, line 433 (link)logic:
sendSurveyEventclears in-progress state when survey is completed but doesn't clear the abandoned flag, allowing abandoned event to fire on next page unload even after completion. Should the abandoned flag be cleared when a survey is completed, to prevent the abandoned event from firing after successful completion?
6 files reviewed, 4 comments
packages/browser/src/extensions/surveys/surveys-extension-utils.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: +5.24 kB (+0.1%) Total Size: 5.3 MB
ℹ️ View Unchanged
|
30bfb40 to
f471898
Compare
|
removed the local storage wrapper import to avoid bloat, dropped from +13kb to +5kb, just double checking i can't reduce that further before merging |

Problem
for surveys with partial responses enabled, there's no good way to know "the user is definitely done with this survey". examples:
survey sentwhere complete=truesurvey dismissedwhere partially complete = trueChanges
emits a new
survey abandonedevent that can fill the gapRelease info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file