-
Notifications
You must be signed in to change notification settings - Fork 216
fix(surveys): only auto-submit on pageload for questoins with auto-submit enabled (hosted surveys) #2790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adboio
merged 1 commit into
main
from
12-18-fix_surveys_only_auto-submit_on_pageload_for_questoins_with_auto-submit_enabled_hosted_surveys_
Dec 18, 2025
Merged
+400
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Contributor
|
Size Change: +648 B (+0.01%) Total Size: 5.3 MB
ℹ️ View Unchanged
|
…bmit enabled (hosted surveys)
4608ca7 to
06fc516
Compare
lucasheriques
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Problem
right now, for hosted surveys, we auto-submit survey responses for prefilled q's on pageload if:
this is almost correct, but does not match the rest of the logic we have...
hosted surveys will skip questions that are 1) prefilled and 2) have auto-submit enabled for that question.
the auto-submit on pageload logic does not consider whether the question has auto-submit enabled, so survey responses are being sent when they shouldn't. this is particularly problematic for email clients pre-fetching links (PR to add optional captcha soon)
Changes
updates logic to only auto-submit questoins that were already skipped in the UI
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file