feat(product tours): enable event and action triggers #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
adboio
commented
Dec 18, 2025
Contributor
Author
There was a problem hiding this comment.
this is basically copied from survey-event-receiver
Contributor
Author
There was a problem hiding this comment.
but ... this is a little risky, so if you'd rather keep surveys as-is and only use this for product tours (for now) -- happy to do that as well
i tested it manually, but our automated testing is a bit lacking here
edit: our tests are actually better than i thought lol. i think this is ok... here is also a diff of the original survey rx file with the new abstract one https://www.diffchecker.com/ZdVJNFsc/
710a254 to
81d745b
Compare
Contributor
Contributor
|
Size Change: +16.1 kB (+0.3%) Total Size: 5.32 MB
ℹ️ View Unchanged
|
81d745b to
7ee3431
Compare
98d9da6 to
6e6f6ab
Compare
6e6f6ab to
ea75a4c
Compare
17 tasks
ea75a4c to
988f0bc
Compare
988f0bc to
bc2ff02
Compare
adboio
commented
Dec 20, 2025
Contributor
Author
There was a problem hiding this comment.
this is before my time, but pretty sure this was flakey because we didn't wait for the api response... i had the same issue with some other tests i added recently. i'd like to keep these enabled
lucasheriques
approved these changes
Dec 20, 2025
Comment on lines
+803
to
+813
| queueTourWithDelay(tourId: string, delaySeconds: number, reason?: ProductTourRenderReason): void { | ||
| logger.info(`Queueing tour ${tourId} with ${delaySeconds}s delay`) | ||
|
|
||
| const timeoutId = setTimeout(() => { | ||
| this._pendingTourTimeouts.delete(tourId) | ||
| logger.info(`Delay elapsed for tour ${tourId}, showing now`) | ||
| this.showTourById(tourId, reason) | ||
| }, delaySeconds * 1000) | ||
|
|
||
| this._pendingTourTimeouts.set(tourId, timeoutId) | ||
| } |
Contributor
There was a problem hiding this comment.
nit: might be worth adding this.cancelPendingTour(tourId) at the start of queueTourWithDelay as a defensive measure. i know _showOrQueueTour already checks isTourPending before calling this, but since queueTourWithDelay is public, someone could call it directly and accidentally overwrite a timeout without cancelling
the previous one
|
|
||
| const logger = createLogger('[Product Tour Event Receiver]') | ||
|
|
||
| export class ProductTourEventReceiver extends EventReceiver<ProductTour> { |
Contributor
There was a problem hiding this comment.
would be good to have some unit tests for ProductTourEventReceiver specifically - especially around _isItemPermanentlyIneligible since it behaves differently than the survey version (checking localStorage for completed/dismissed state)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
product tours should be trigger-able through events or actions
Changes
make them!
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file