-
Notifications
You must be signed in to change notification settings - Fork 13
Release v0.8.8 #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.8.8 #1036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the version to v0.8.8 and refines the bootstrap delay logic to enforce a minimal wait (1ns) for tipset availability and reduce hot-looping (20ms).
- Updated version.json to v0.8.8
- Modified computeBootstrapDelay to never return zero in the waiting branch
- Added a minimum 20ms wait in F3.Start to prevent tight loops
- Adjusted existing test to expect 1ns instead of 0s
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| version.json | Updated version string to v0.8.8 |
| f3.go | Added minimum delay of 1ns and 20ms clamp logic |
| bootstrap_delay_test.go | Changed expected delay from 0s to 1ns in test case |
Comments suppressed due to low confidence (2)
f3.go:139
- The comment’s description of the return conditions is inverted and doesn’t reflect the new 1ns clamp. Consider rewording to explain that when currentEpoch ≥ BootstrapEpoch, the function returns 0, and otherwise returns at least 1ns.
// It will return 0 if the manifest bootstrap epoch is greater than the current epoch.
bootstrap_delay_test.go:67
- Add a test case for the scenario where
currentEpoch == BootstrapEpochto ensure the function returns the expected minimal delay of 1ns.
want: 1 * time.Nanosecond, // we don't start immediately as the tipset we need is not available yet
Contains a simple fix for test condition bootstrap. Signed-off-by: Jakub Sztandera <[email protected]>
|
Suggested version: Changes in configuration file(s): (empty)
Automatically created GitHub ReleaseA draft GitHub Release has been created. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
- Coverage 65.32% 65.24% -0.09%
==========================================
Files 80 80
Lines 9707 9707
==========================================
- Hits 6341 6333 -8
- Misses 2867 2875 +8
Partials 499 499 🚀 New features to boost your workflow:
|
Contains a simple fix for test condition bootstrap.