Skip to content

Conversation

@Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Jul 8, 2025

Contains a simple fix for test condition bootstrap.

Copilot AI review requested due to automatic review settings July 8, 2025 12:58
@github-project-automation github-project-automation bot moved this to Todo in F3 Jul 8, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version to v0.8.8 and refines the bootstrap delay logic to enforce a minimal wait (1ns) for tipset availability and reduce hot-looping (20ms).

  • Updated version.json to v0.8.8
  • Modified computeBootstrapDelay to never return zero in the waiting branch
  • Added a minimum 20ms wait in F3.Start to prevent tight loops
  • Adjusted existing test to expect 1ns instead of 0s

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
version.json Updated version string to v0.8.8
f3.go Added minimum delay of 1ns and 20ms clamp logic
bootstrap_delay_test.go Changed expected delay from 0s to 1ns in test case
Comments suppressed due to low confidence (2)

f3.go:139

  • The comment’s description of the return conditions is inverted and doesn’t reflect the new 1ns clamp. Consider rewording to explain that when currentEpoch ≥ BootstrapEpoch, the function returns 0, and otherwise returns at least 1ns.
// It will return 0 if the manifest bootstrap epoch is greater than the current epoch.

bootstrap_delay_test.go:67

  • Add a test case for the scenario where currentEpoch == BootstrapEpoch to ensure the function returns the expected minimal delay of 1ns.
			want: 1 * time.Nanosecond, // we don't start immediately as the tipset we need is not available yet

@github-project-automation github-project-automation bot moved this from Todo to In review in F3 Jul 8, 2025
Contains a simple fix for test condition bootstrap.

Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu enabled auto-merge July 8, 2025 13:07
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

Suggested version: 0.8.8

Comparing to: v0.8.7 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# diagnostics
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.8.8

gocompat says:

HEAD is now at d713c5a Bump version to 0.8.7 (#1033)
Previous HEAD position was d713c5a Bump version to 0.8.7 (#1033)
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.24%. Comparing base (08b78bc) to head (836fe88).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
- Coverage   65.32%   65.24%   -0.09%     
==========================================
  Files          80       80              
  Lines        9707     9707              
==========================================
- Hits         6341     6333       -8     
- Misses       2867     2875       +8     
  Partials      499      499              

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kubuxu Kubuxu added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit 73dd2a3 Jul 8, 2025
19 checks passed
@Kubuxu Kubuxu deleted the release/v0.8.8 branch July 8, 2025 13:38
@github-project-automation github-project-automation bot moved this from In review to Done in F3 Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants