Feature #19018
closed
uri/generic: Support CIDR blocks in comma-delimited entries in no_proxy
Description
Currently URI::Generic.use_proxy? does not treat the no_proxy strings as a comma-delimited value: https://github.com/ruby/ruby/blob/0ed71b37fa9af134fdd5a7fd1cebd171eba83541/lib/uri/generic.rb#L1545-L1564
That means that it's not possible to specify multiple rules, such as:
no_proxy=.example.com,192.168.0.0/8
While there's no official standard for no_proxy(https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/), Python and Golang split the comma.
Updated by stanhu (Stan Hu) over 2 years ago
I submitted https://github.com/ruby/ruby/pull/6424. That method could use some cleanup.
Updated by stanhu (Stan Hu) over 2 years ago
- Subject changed from uri/generic: Support comma-delimited entries in no_proxy to uri/generic: Support CIDR blocks in comma-delimited entries in no_proxy
Updated by stanhu (Stan Hu) over 2 years ago
Ok, I'm wrong. This seems to work. We can close this issue. Turns out the problem is in gRPC, not Ruby: https://github.com/grpc/grpc/issues/22681
Updated by jeremyevans0 (Jeremy Evans) over 2 years ago
- Status changed from Open to Closed